-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentDB support #706
DocumentDB support #706
Conversation
- ChangeEvent enum tagged - AnyDocument common type created
…tdb-drop-database-support
Thanks a lot for opening this PR! I just merged some fixes for tests that were failing and were unrelated to your changes. Can you rebase from the main branch and resolve the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this new feature here? https://github.com/awslabs/aws-lambda-rust-runtime/blob/main/Makefile#L66
It looks like you also need to run cargo fmt
. See failure here: https://github.com/awslabs/aws-lambda-rust-runtime/actions/runs/6564020165/job/17831737888?pr=706#step:5:17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rebase from main
again? it looks like the eventbridge changes created a conflict. It might be better to put the Makefile changes in alphabetical order to prevent future conflicts like this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! LGTM
Issue #, if available:
Description of changes:
DocumentDB event support created.
It was considered that this service only supports mongo events up to version 5. However, as in version 6 there are greater variations of fields in the structs, it was decided to duplicate this initially to facilitate future updates when version 6 is supported.
The supported events and their links are:
In all the structs, the "operation_type" field has been commented out to mention its existence, but it should not be defined in the code because it is only used when deserializing the entry in the "ChangeEvent" enum configured as follows:
#[serde(tag = "operationType", rename_all = "camelCase")]
By submitting this pull request