Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compile_error if no http features are enabled #698

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Sep 17, 2023

Issue #, if available:

Fixes #697

Description of changes:

  • Provide help so people know that they have to enable a feature.
  • Put imports in place so conditional compilation doesn't try to compile unnecessary code.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

/cc @jdisanti

- Provide help so people know that they have to enable a feature.
- Put imports in place so conditional compilation doesn't try to compile unnecesary code.

Signed-off-by: David Calavera <[email protected]>
@calavera calavera force-pushed the http_feature_compile_error branch from 4e77fdb to 0b1fac5 Compare September 17, 2023 19:14
@awslabs awslabs deleted a comment from github-actions bot Sep 17, 2023
@calavera calavera merged commit 722e33f into main Sep 18, 2023
7 checks passed
@calavera calavera deleted the http_feature_compile_error branch September 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda_http fails to compile with default-features = false
2 participants