Refactor Lambda response streaming. #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the separate streaming.rs from lambda-runtime crate. Merge into the `run` method. Added FunctionResponse enum to capture both buffered response and streaming response. Added IntoFunctionResponse trait to convert `Serialize` response into FunctionResponse::BufferedResponse, and convert `Stream` response into FunctionResponse::StreamingResponse. Existing handler functions should continue to work. Improved error handling in response streaming. Return trailers to report errors instead of panic.
calavera
reviewed
Sep 14, 2023
|
|
||
| req_headers.insert("Transfer-Encoding", "chunked".parse()?); | ||
| req_headers.insert("Lambda-Runtime-Function-Response-Mode", "streaming".parse()?); | ||
| req_headers.append("Trailer", "Lambda-Runtime-Function-Error-Type".parse()?); |
There was a problem hiding this comment.
can you leave a comment explaining what these Trailer headers are for?
|
This looks good at first glance. I'm going to run some tests today before merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the separate streaming.rs from lambda-runtime crate. Merge into the
runmethod.Added FunctionResponse enum to capture both buffered response and streaming response.
Added IntoFunctionResponse trait to convert
Serializeresponse into FunctionResponse::BufferedResponse, and convertStreamresponse into FunctionResponse::StreamingResponse. Existing handler functions should continue to work.Improved error handling in response streaming. Return trailers to report errors instead of panic.
By submitting this pull request