Added support for arm64, shared runtimes. #6
Conversation
| @@ -0,0 +1,137 @@ | |||
| <Objs Version="1.1.0.1" xmlns="http://schemas.microsoft.com/powershell/2004/04"> | |||
There was a problem hiding this comment.
Instead of embedding this module, can the readme be adjusted to note how to download it into the correct folder as part of the build process?
Eg, to run Save-Module -Name WriteAscii -Path ./modules/ in the relevant location?
I primarily ask this because 1.2.2 is already out of date, and I don't want our team to monitor this module for bugs or potential security implications in the future.
Find-Module -Name WriteAscii | Select-Object Name,Version
Name Version
---- -------
WriteAscii 1.2.2.1| From a command prompt, invoke the function. Amend the `--function-name` and `--region` values for your function. This should return `"StatusCode": 200` for a successful invoke. | ||
|
|
||
| ```` | ||
| aws lambda invoke --function-name "DemoAsciiArtFunction-6W3bn1znmW8G" --region us-east-1 invoke-result |
There was a problem hiding this comment.
Might need to note how to find the function name, as I'd imagine the generated part of of this name will not be the same for each customer or region where this is deployed.
| PWSH_ARCHITECTURE ?= x64 | ||
| #x64 or #arm64 | ||
| PWSH_VERSION ?= 7.2.7 | ||
|
|
There was a problem hiding this comment.
I think we need either one of two changes here, as building the runtime from the powershell-runtime folder fails with this change as PWSH_ARCHITECTURE is no longer defined.
- Keep
PWSH_ARCHITECTURE = x64here as a default for buildingPwshRuntimeLayer(the current layer name in thepowershell-runtime/template.ymlfile), or - Modify
powershell-runtime/template.ymlto include two layers, one forx64and one forarm64.
Issue #, if available:
Description of changes:
Added support for arm64, shared runtimes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.