Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #432 Build broken with JDK 21 #433

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

stefanofornari
Copy link
Contributor

Issue #, if available:
#432

Description of changes:
fix for #432 Build broken with JDK 21

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefanofornari stefanofornari deleted the main-upstream branch April 10, 2024 06:24
@stefanofornari stefanofornari restored the main-upstream branch April 10, 2024 06:30
@stefanofornari
Copy link
Contributor Author

Sorry, as usual, I deleted the branch before PR is merged...

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try using the S3AsyncClient directly rather than casting it?

@markjschreiber
Copy link
Contributor

I can see why there is an ambiguity but it's weird this only shows up in Java21. I have re-opened the PR for you and added a comment on it.

@stefanofornari
Copy link
Contributor Author

I should have done...

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@markjschreiber
Copy link
Contributor

fixes #432

@markjschreiber markjschreiber merged commit 43cba86 into awslabs:main Apr 11, 2024
1 check passed
@stefanofornari stefanofornari deleted the main-upstream branch May 20, 2024 05:05
stefanofornari added a commit to stefanofornari/aws-java-nio-spi-for-s3 that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants