Fix repository creation permission in pipeline management #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** When a CodeCommit repository was supposed to be created, it would fail with the following error message: > An error occurred (AccessDenied) when calling the AssumeRole operation: > User: arn:aws:sts::111111111111:assumed-role/adf-global-base-deploymen-CreateRepositoryLambdaRo-GP8W3IRDCGY2/ADFPipelineCreateRepositoryFunction > is not authorized to perform: sts:AssumeRole on resource: > arn:aws:iam::111111111111:role/adf-automation-role > Traceback (most recent call last): > File "/var/task/create_repository.py", line 48, in lambda_handler > repo = Repo( > File "/opt/python/repo.py", line 36, in __init__ > self.session = sts.assume_cross_account_role( > File "/opt/python/sts.py", line 24, in assume_cross_account_role > sts_response = self.client.assume_role( > File "/var/runtime/botocore/client.py", line 391, in _api_call > return self._make_api_call(operation_name, kwargs) > File "/var/runtime/botocore/client.py", line 719, in _make_api_call > raise error_class(parsed_response, operation_name) **What?** Updated the crate repository role and create/update rule roles to include a role name. Updated the `adf-automation-role` assume role permissions to allow these two roles to assume into it.
StewartW
approved these changes
Sep 27, 2022
javydekoning
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When a CodeCommit repository was supposed to be created, it would fail with the following error message:
What?
Updated the crate repository role and create/update rule roles to include a role name. Updated the
adf-automation-roleassume role permissions to allow these two roles to assume into it.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.