Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 372: Pipeline Triggers #392

Merged
merged 22 commits into from
Nov 17, 2021
Merged

Feature 372: Pipeline Triggers #392

merged 22 commits into from
Nov 17, 2021

Conversation

StewartW
Copy link
Contributor

@StewartW StewartW commented Oct 8, 2021

Issue #, if available:
#372

Description of changes:
Updated adf_default_pipeline to be able to add in additional triggers for the CodePipeline.
First one is the customer requested Code Artifact.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StewartW

This comment has been minimized.

@StewartW StewartW requested review from kalleeh and sbkok October 18, 2021 12:11
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs. I have left a few review comments, please reach out to me if you need support or if anything is unclear.

docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
StewartW and others added 7 commits November 10, 2021 15:24
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py

Co-authored-by: Simon <[email protected]>
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py

Co-authored-by: Simon <[email protected]>
StewartW and others added 3 commits November 17, 2021 10:53
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py

Co-authored-by: Simon Kok <[email protected]>
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py

Co-authored-by: Simon Kok <[email protected]>
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks!!

@sbkok sbkok added this to the v3.2.0 milestone Nov 17, 2021
Copy link
Collaborator

@thomasmcgannon thomasmcgannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature! lgtm!

@sbkok sbkok merged commit e1a8b03 into awslabs:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants