-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 372: Pipeline Triggers #392
Conversation
This comment has been minimized.
This comment has been minimized.
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the docs. I have left a few review comments, please reach out to me if you need support or if anything is unclear.
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Outdated
Show resolved
Hide resolved
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/schema_validation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py Co-authored-by: Simon <[email protected]>
…ild/shared/schema_validation.py Co-authored-by: Simon <[email protected]>
…ild/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py Co-authored-by: Simon <[email protected]>
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
..._commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/tests/test_pipeline_creation.py
Show resolved
Hide resolved
27b279a
to
38422d6
Compare
38422d6
to
4b5eb95
Compare
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Kok <[email protected]>
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codepipeline.py
Outdated
Show resolved
Hide resolved
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py Co-authored-by: Simon Kok <[email protected]>
…ild/shared/cdk/cdk_constructs/adf_codepipeline.py Co-authored-by: Simon Kok <[email protected]>
…ework into feature/372
.../initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_stacks/adf_default_pipeline.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice feature! lgtm!
Issue #, if available:
#372
Description of changes:
Updated adf_default_pipeline to be able to add in additional triggers for the CodePipeline.
First one is the customer requested Code Artifact.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.