Add ability to disable trigger on changes for S3/CC/GH source providers #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?** For several use cases, it would be great to have a pipeline that would not trigger on source updates. For example, a pipeline might only need to be triggered on a schedule, by the completion of another pipeline, or manually. This was requested by the following issues: * Issue awslabs#308 - Starting pipeline only on completion_trigger * Issue awslabs#337 - Question: Disable webhook for Github provider **What?** The CodeCommit, Github, and S3 source providers have been update to support disabling triggering on source changes. As described in the `docs/providers-guide.md` documentation, you can optionally disable it when required. This code also solves a bug when a pipeline would rely on polling of changes for CodeCommit. In the previous version, it would be triggering twice instead of once when the source account id was specified. As the event handler would be listening for events that indicate an update was performed, even when the pipeline was set to use polling for changes instead of events.
thomasmcgannon
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For several use cases, it would be great to have a pipeline that would not trigger on source updates.
For example, a pipeline might only need to be triggered on a schedule, by the completion of another pipeline, or manually.
This was requested by the following issues:
What?
The CodeCommit, Github, and S3 source providers have been update to support disabling triggering on source changes.
As described in the
docs/providers-guide.mddocumentation, you can optionally disable it when required.This code also solves a bug when a pipeline would rely on polling of changes for CodeCommit. In the previous version, it would be triggering twice instead of once when the source account id was specified. As the event handler would be listening for events that indicate an update was performed, even when the pipeline was set to use polling for changes instead of events.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.