Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.6 #261

Merged
merged 1 commit into from
Apr 28, 2020
Merged

3.0.6 #261

merged 1 commit into from
Apr 28, 2020

Conversation

bundyfx
Copy link
Contributor

@bundyfx bundyfx commented Apr 26, 2020 •
edited
Loading

Issue #, if available:

Resolves #260
Resolves #91

Description of changes:

  • CDK Version 1.25 -> 1.32
  • Account Alias’ are no longer automatically created as the accounts full name.
  • Adding ability to tag pipelines
  • Adding in cloudformation:* in global-iam-example.yml for target accounts.
  • Adding in additional wait time for account creation process (Temporary Fix)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bundyfx bundyfx requested review from sbkok and deltagarrett April 26, 2020 11:13
@bundyfx bundyfx force-pushed the 3.0.6 branch 3 times, most recently from 7002f77 to 190d6c9 Compare April 26, 2020 11:34
deltagarrett
deltagarrett approved these changes Apr 26, 2020
View reviewed changes
Copy link

@deltagarrett deltagarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sbkok
sbkok approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@sbkok sbkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding pipeline tag support!

@bundyfx bundyfx merged commit 8ae0f35 into master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbkok sbkok sbkok approved these changes

@deltagarrett deltagarrett deltagarrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bundyfx @deltagarrett @sbkok