Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel executions of aws-deployment-framework-bootstrap-pipeline leads to failure in CodeBuild #270

Closed
mdaehnert opened this issue Jun 5, 2020 · 1 comment
Closed

Parallel executions of aws-deployment-framework-bootstrap-pipeline leads to failure in CodeBuild #270

mdaehnert opened this issue Jun 5, 2020 · 1 comment
Assignees
@sbkok
Milestone
v3.2.0

Comments

@mdaehnert
Copy link
Contributor

Description

When a change is made to CodeCommit:aws-deployment-framework-bootstrap/* multiple times in a short period of time, it leads to an error inside CodeBuild:aws-deployment-framework-base-templates.

Info

  • ADF version: 3.0.6
  • Reproducible: Always

Expected Behavior

CodeBuild should run multiple times without any issue. (1. run with the first CodeCommit change, 2. run with the second change, ...)

Steps to reproduce

  1. Edit any file inside CodeCommit:aws-deployment-framework-bootstrap and push it.
  2. Do an edit+push again (within 1-2 minutes)
  3. Go to CodeBuild:aws-deployment-framework-base-templates and you can see the error:
CLIENT_ERROR: NoSuchKey: The specified key does not exist. status code: 404,
request id: 2C756B0562D8D657,
host id: MY+Nw7YKRaPmZpHizWSx0P5F7luKZXChIccEOvBxWQHgDWGvCSKy7/ZOhwQIVuEiETzDk2qN3X0=
for primary source and source version
arn:aws:s3:::serverlessrepo-aws-deplo-bootstraptemplatesbucket-[...]/aws-deployment-frame/TemplateSo/[...]

image

Reason

Solution

Use a separate ArtifactBucket for CodePipeline and for CodeBuild to store its created data.
mdaehnert added a commit to mdaehnert/aws-deployment-framework that referenced this issue Jun 5, 2020
@mdaehnert
awslabs#270 - CodePipeline/Codebuild now uses a separate ArtifactStor…
014be0a 
…age bucket.
@mdaehnert mdaehnert mentioned this issue Jun 5, 2020
Merged
sbkok pushed a commit that referenced this issue Apr 9, 2021
@mdaehnert
#270 - CodePipeline/Codebuild now uses a separate ArtifactStorage buc…
9d1a471 
…ket. (#271)

Authored-by: Michael Dähnert <[email protected]>
Signed-off-by: Simon <[email protected]>
sbkok added a commit to sbkok/aws-deployment-framework that referenced this issue Apr 12, 2021
@sbkok
Lock down buckets created by ADF - no public access
ae59392 
**Why?**

By default, ADF does not mark any object or bucket to be accessibly
publicly. However, the buckets did not restrict any other process from
doing so anyway.

**What?**

To ensure objects are not accidentally made public, this change will
enforce that. Changing the object or bucket policies to public would not
be allowed.

Additionally, one bucket, the BootstrapArtifactStorageBucket that was
added recently by awslabs#270 did not configure encryption and versioning.
This was not released as part of ADF yet, so no data was exposed.

The samples that deployed buckets are also updated to include the
encryption, versioning, and block-public access properties.
@sbkok sbkok mentioned this issue Apr 12, 2021
Merged
sbkok added a commit that referenced this issue Apr 14, 2021
@sbkok
Lock down buckets created by ADF - no public access (#350)
ef461d5 
**Why?**

By default, ADF does not mark any object or bucket to be accessibly
publicly. However, the buckets did not restrict any other process from
doing so anyway.

**What?**

To ensure objects are not accidentally made public, this change will
enforce that. Changing the object or bucket policies to public would not
be allowed.

Additionally, one bucket, the BootstrapArtifactStorageBucket that was
added recently by #270 did not configure encryption and versioning.
This was not released as part of ADF yet, so no data was exposed.

The samples that deployed buckets are also updated to include the
encryption, versioning, and block-public access properties.
@sbkok sbkok added this to the v3.2.0 milestone Nov 8, 2021
@sbkok
Copy link
Collaborator

sbkok commented Jan 24, 2023

Thank you for your patience. I am happy to inform you that this issue has been resolved in our latest release v3.2.0 just now.
I'm hereby closing this issue. Please open a new issue if you are experiencing any issues with the latest release.

@sbkok sbkok closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbkok sbkok

Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
2 participants
@mdaehnert @sbkok