Fix "Cannot find module" for aws-crt-nodejs #522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lib/native/bindings.js, after successfully finding the aws-crt-nodejs native module, it drops the *.node* extension when calling require. That should be fine in a pure commonJs environment but dropping the extension breaks some ES-like runtime and build environments. This PR includes the extension in the require call. I don't see a test to update. (Consider adding some? There seem to be a lot of regressions in aws-sdk-js-v3 relating to aws-crt and signature-v4-crt. It would take a lot of work around test fixtures but perhaps worthwhile/justified?)
Merged
|
Should be superceded by #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In
lib/native/bindings.js, after successfully finding the aws-crt-nodejs native module, it drops the .node extension when calling require. That should be fine in a pure commonJs environment but dropping the extension breaks some ES-like runtime and build environments.This PR includes the extension in the require call.
I don't see a test to update. (Consider adding some? There seem to be a lot of regressions in aws-sdk-js-v3 relating to aws-crt and signature-v4-crt. It would take a lot of work around test fixtures but perhaps worthwhile/justified?)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.