Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend upon Kotlin 1.5 #7

Merged
merged 3 commits into from
May 24, 2021
Merged

Depend upon Kotlin 1.5 #7

merged 3 commits into from
May 24, 2021

Conversation

kggilmer
Copy link
Contributor

Issue #, if available: smithy-lang/smithy-kotlin#319

This PR is in draft form until important Kotlin lib dependencies we use are on 1.5x (currently this is the coroutines dep still in RC status for 1.5)

Description of changes:
Bump version of Kotlin compiling runtime and services against to resolve runtime classpath issue that is hit when depending on 1.4x built version of SDK (see issue for more details)

Testing Done

  • Build and locally deploy S3 SDK with changes. Observe that simple example program, does not have runtime classpath error as was present before change. Confirm example works when depending on both Kotlin 1.4.x and 1.5.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kggilmer kggilmer marked this pull request as ready for review May 21, 2021 00:39
@kggilmer kggilmer requested review from aajtodd and ianbotsf May 21, 2021 00:39
@kggilmer kggilmer merged commit a579296 into main May 24, 2021
@kggilmer kggilmer deleted the chore-kotlin-1_5_update branch May 24, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants