fix conn pool leak when acquire future is cancelled #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
approved these changes
Feb 1, 2022
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.*; |
There was a problem hiding this comment.
Very minor and probably a result of IDE settings, but I think we have a preference for keeping imports explicit and not wild-carded.
There was a problem hiding this comment.
yup IDE auto import settings, will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
see awslabs/aws-sdk-kotlin#511
Description of changes:
Check if the connection acquire future is actually completed by the callback. If not (likely due to cancellation) then return it immediately to the pool otherwise it will leak and future acquisitions will fail/hang.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.