Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing checksum with no signing #459

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Nov 8, 2024

Issue #, if available:

  • When you do trialing checksum, apparently, you need to have the x-amz-content-sha256 header to be set to the special value even if you are not signing the request.

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (e373ef4) to head (dd0f49e).

Files with missing lines Patch % Lines
source/s3_meta_request.c 77.77% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   89.62%   89.64%   +0.01%     
==========================================
  Files          20       20              
  Lines        6142     6144       +2     
==========================================
+ Hits         5505     5508       +3     
+ Misses        637      636       -1     
Files with missing lines Coverage Δ
source/s3_client.c 90.09% <ø> (ø)
source/s3_meta_request.c 91.88% <77.77%> (+0.11%) ⬆️

@TingDaoK TingDaoK marked this pull request as draft November 11, 2024 17:08
@TingDaoK TingDaoK marked this pull request as ready for review November 18, 2024 18:47
tests/s3_mock_server_tests.c Outdated Show resolved Hide resolved
include/aws/s3/private/s3_client_impl.h Outdated Show resolved Hide resolved
source/s3_meta_request.c Outdated Show resolved Hide resolved
source/s3_meta_request.c Outdated Show resolved Hide resolved
@@ -936,17 +941,6 @@ void aws_s3_meta_request_sign_request_default_impl(
(void *)request,
(void *)request->send_data.message);

if (request->send_data.signable == NULL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job shuffling around these log statements and if-checks
makes more sense now
👍

@TingDaoK TingDaoK requested a review from graebm November 21, 2024 18:33
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

source/s3_meta_request.c Outdated Show resolved Hide resolved
@TingDaoK TingDaoK merged commit 0b006a6 into main Nov 27, 2024
31 checks passed
@TingDaoK TingDaoK deleted the no-signing-trialer branch November 27, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants