-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trailing checksum with no signing #459
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 89.62% 89.64% +0.01%
==========================================
Files 20 20
Lines 6142 6144 +2
==========================================
+ Hits 5505 5508 +3
+ Misses 637 636 -1
|
@@ -936,17 +941,6 @@ void aws_s3_meta_request_sign_request_default_impl( | |||
(void *)request, | |||
(void *)request->send_data.message); | |||
|
|||
if (request->send_data.signable == NULL) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job shuffling around these log statements and if-checks
makes more sense now
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix & ship
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.