support meta request level override of part size and mpu threshold #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 88.67% 88.67% -0.01%
==========================================
Files 21 21
Lines 5945 5962 +17
==========================================
+ Hits 5272 5287 +15
- Misses 673 675 +2
|
graebm
approved these changes
Dec 12, 2023
source/s3_client.c
Outdated
Comment on lines
1255
to
1268
| size_t adjusted_part_size = part_size_config; | ||
| uint32_t num_parts = 0; | ||
| if (content_length_found) { | ||
| if (aws_s3_calculate_optimal_mpu_part_size_and_num_parts( | ||
| content_length, client_part_size, client_max_part_size, &part_size, &num_parts)) { | ||
| content_length, part_size_config, client_max_part_size, &adjusted_part_size, &num_parts)) { | ||
| return NULL; | ||
| } | ||
| } | ||
| if (adjusted_part_size != part_size_config) { | ||
| AWS_LOGF_DEBUG( | ||
| AWS_LS_S3_META_REQUEST, | ||
| "The multipart upload part size has been adjusted to %" PRIu64 "", | ||
| (uint64_t)adjusted_part_size); | ||
| } |
There was a problem hiding this comment.
trivial: I would move this logic up before we set multipart_upload_threshold. Then, if part-size gets adjusted, the multipart_upload_threshold will also be adjusted.
Also, not sure it's worth the potential confusion of having 2 part_size_config and adjusted_part_size variables? Maybe just have 1 part_size variable that we update as the function progresses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.