Device Defender changes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Mar 16, 2022
…removed int returns on registering custom metrics
|
Will check and fix what is causing the tests to fail. I think it is just something minor due to removing a constant or something |
|
Thanks for the review! I adjusted the code and it's all working again 👍 |
bretambrose
reviewed
Mar 23, 2022
…ent back to prefix style
|
Thanks for the review! I adjusted the code accordingly 👍 |
bretambrose
approved these changes
Mar 28, 2022
…ceDefenderCustomMetricsSupport
…ceDefenderCustomMetricsSupport
bretambrose
approved these changes
Apr 27, 2022
|
Thanks for the reviews! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjusts the custom metrics clean up function to clear the memory for the array in custom string-list and ip-list metrics. It also adds support for double numbers and double number lists, allowing for numbers with decimals to be used in the resulting JSON.
Leaving as draft currently as it may need additional changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.