Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for host resolution override per connection #434

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

bretambrose
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose bretambrose marked this pull request as ready for review April 11, 2023 17:23
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02 ⚠️

Comparison is base (0600662) 80.17% compared to head (f2dd499) 80.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   80.17%   80.15%   -0.02%     
==========================================
  Files          27       27              
  Lines       11524    11530       +6     
==========================================
+ Hits         9239     9242       +3     
- Misses       2285     2288       +3     
Impacted Files Coverage Δ
source/proxy_connection.c 73.99% <75.00%> (+<0.01%) ⬆️
source/connection.c 80.12% <100.00%> (+0.04%) ⬆️
source/websocket_bootstrap.c 89.49% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bretambrose bretambrose merged commit c735009 into main Apr 11, 2023
@bretambrose bretambrose deleted the ResolutionOverride branch April 11, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants