CMake package should add the modules to CMAKE_MODULE_PATH #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now aws-c-event-stream needs a lot of boilerplate code to determine the modules installation path while the aws-c-common package should provide it. This would fix awslabs/aws-c-event-stream#15 simply by moving `find_package(aws-c-common)` before the various module `include`s Using `configure_package_config_file` makes it easier to have a relocatable package.
2 tasks
|
Thanks for this great suggestion. Closing this PR to take care of it in a newer one here (along with a bunch of other little fixes): #1178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is the same as #587, but rebased and reissued against the new main branch)
Right now aws-c-event-stream needs a lot of boilerplate code to determine the modules installation path while the aws-c-common package should provide it.
This would fix awslabs/aws-c-event-stream#15 simply by moving
find_package(aws-c-common)before the various moduleincludesUsing
configure_package_config_filemakes it easier to have a relocatable package.Issue #, if available:
Closes #844
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.