Fix several issues in BUILDING.md, add missing config options #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2020 16:18
Other changes: - Moved all the deployer config docs from the example file to BUILDING.md for easier reading and formatting. - Removed from the user-visible docs any trace of the `'request'` mode for account registration, as it's not currently supported and the existing implementation is untested and critically broken. It's just commented out, so anyone who views the source code can still see traces of it (and infer that it's a likely WIP feature). - Revised the deployment scripts so I could better understand the numerous points of configuration. (It helped me write the rest of this patch.)
ghost
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
skylarbemus
approved these changes
Jun 5, 2020
ghost
force-pushed
the
clarify-deployer-config
branch
from
576c036 to
0a508cc
Compare
MynockSpit
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.