Fix npm audit warnings #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
requested review from
bejos-zz,
etsung-aws,
MynockSpit,
nitishdayal and
echo-bravo-yahoo
as code owners
|
Note: this PR doesn't quite work as it currently stands. It overwrites a manual patch (documented here: https://github.com/Trial-In-Error/swagger-ui/commit/ffc9f5d79ec84c9fd6b7d44d35da309a62f4e2e8) that resolves a UI error, which we will need to maintain. To get around this, we should update @Trial-In-Error's fork of swagger-ui with updates from v3.22.3 (latest), and then use that fork as a npm dependency (using the git URL as the source) rather than upstream. |
MynockSpit
approved these changes
Jun 26, 2019
echo-bravo-yahoo
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several critical- and moderate-severity vulnerabilities shown by npm audit. The primary changes are package upgrades for react-scripts and swagger-ui. This also requires a change to
compilerOptions.baseUrlinjsconfig.jsonas of react-scripts 3.0.0, but thankfully this does not require any changes to import statements the source code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.