Run npm install upon npm run get-dependencies
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
requested review from
a-tan,
bejos-zz,
etsung-aws,
MynockSpit,
nitishdayal and
echo-bravo-yahoo
as code owners
MynockSpit
approved these changes
Jun 26, 2019
echo-bravo-yahoo
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npm run get-dependencies, I expect all dependencies to be installed so that I can build or test the package. However, because we previously did not runnpm installas part of this command, some dependencies (such as xml-js) were missing. This PR resolves that issue.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.