Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of existing user pool #279

Closed
wants to merge 14 commits into from
Closed

Allow usage of existing user pool #279

wants to merge 14 commits into from

Conversation

nimrodkor
Copy link

Description of changes:
Added two parameters to allow usage of existing User Pool instead of creating a new one.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ghost
Copy link

ghost commented Apr 13, 2020

Could you fix the merge conflicts?

@nimrodkor
Merge remote-tracking branch 'aws/staging' into staging
a688b66 
# Conflicts:
#	cloudformation/template.yaml
@nimrodkor
Copy link
Author

@amazon-meaisiah Done!

@nimrodkor
Copy link
Author

nimrodkor commented Apr 18, 2020 •
edited
Loading

Hey again @amazon-meaisiah !

I tested it out on our environment - and for some reason, the URL for the existing cognito user pool is broken in the UI. When I try to sign in, it sends me to https://developers.test.com/<COGNITO_URL>
Instead of https://<COGNITO_URL>. Tried to fix it but had a hard time. Any possible help here?

ghost
ghost suggested changes May 1, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the backup files, the *.un~ files?

@ghost
Copy link

ghost commented May 1, 2020

@nimrodkor Not sure personally based on a cursory look at the code, but I'll see if I can work with other team members to figure out what's going on or if I just missed something.

nimrodkor added 2 commits May 2, 2020 12:19
@nimrodkor
Remove temp files (#6)
57c503a 
* Delete .History.md.un~

* Delete .Readme.md.un~

* Delete .package.json.un~

* Delete .index.js.un~
@nimrodkor
Merge branch 'staging' into staging
0723fe2
@nimrodkor
Copy link
Author

@amazon-meaisiah Removed the temp files, sorry about that!

@nimrodkor nimrodkor requested a review from zil-aws as a code owner June 1, 2021 23:56
@ghost ghost closed this Jun 2, 2021
@ghost ghost deleted the branch awslabs:staging June 2, 2021 00:00
@talipini
Copy link

talipini commented Oct 3, 2021

@nimrodkor - Looks like this change was merged in a while ago but it is not in the latest any more. Any ideas on what happened to it? Were there any issues with this? thanks

@snyk-bot snyk-bot mentioned this pull request Jul 21, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejos-zz bejos-zz Awaiting requested review from bejos-zz

@etsung-aws etsung-aws Awaiting requested review from etsung-aws

@MynockSpit MynockSpit Awaiting requested review from MynockSpit

@nitishdayal nitishdayal Awaiting requested review from nitishdayal

@echo-bravo-yahoo echo-bravo-yahoo Awaiting requested review from echo-bravo-yahoo

@jiyou95 jiyou95 Awaiting requested review from jiyou95

@skylarbemus skylarbemus Awaiting requested review from skylarbemus

@zil-aws zil-aws Awaiting requested review from zil-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimrodkor @talipini