-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #293
Upgrade dependencies #293
Conversation
@@ -45,7 +45,7 @@ jobs: | |||
- name: Set up Nodejs 12 | |||
uses: actions/setup-node@v1 | |||
with: | |||
node-version: 12 | |||
node-version: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create React App v5 includes loads of warnings for node 12 so I moved all to node 14.
@@ -50,13 +50,13 @@ format-cfn: | |||
|
|||
.PHONY: format-docs | |||
format-docs: | |||
npx prettier-eslint ./*.md ./docs/*.md --write --prose-wrap always | |||
npx prettier ./*.md ./docs/*.md --write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create React App v5 moved internally to ESLint 8, and prettier-eslint cli is stuck to ESLint 5: prettier/prettier-eslint-cli#304
When upgrading, prettier-eslint was failing. I decided to just move to prettier cli, which has a --write
functionality as well. The difference is that instead of inferring the linting config from the Create React App module, I am defining the config inside the root's package.json
. But the advantage is that the dependency tree is much smaller and that allows to remove some vulnerabilities too.
When running with just prettier, the linting is 99% same. You'll notice a couple of new line changes in 5 JavaScript files, but I decided that it was ok for now.
@@ -140,7 +140,7 @@ def glue_columns(): | |||
] | |||
|
|||
|
|||
@pytest.fixture(scope="session", autouse=True) | |||
@pytest.fixture(scope="module", autouse=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an issue here when running the acceptance tests. They ran for 64 minutes, and everything running during the last 4 failed with 401 status codes because the token was expired. So I decided to move the cognito token fetch from session to module in order to reduce the probability of that happening again.
Update some dependencies. See in-line comments for some details about a couple of changes I had to do in order to simplify dependency management.
PR Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.