[Sample] GStreamer media receiver #1963

niyatim23 · 2024-04-03T04:33:16Z

Issue #, if available:
#1946

What was changed?

Introduced GStAudioVideoReceiver.c and kvsWebrtcClientViewerGstSample to write media received by either the master or the viewer by setting receiveAudioVideoSource appropriately

Why was it changed?

Currently there is no way to consume the media received by the viewer. We just log it. Instead, with this change, we would now write it to a file using GStreamer

How was it changed?

Introduced kvsWebrtcClientViewerGstSample
Introduced GStAudioVideoReceiver contains the transceiver callbacks, the receiveGstreamerAudioVideo which contains the GStreamer pipeline to obtain media via appsrc
Updated one of the builds to run with ENABLE_GST_SAMPLE_RECEIVER
Added an H265 / AAC source pipeline to kvsWebrtcClientMasterGstSample

What testing was done for the changes?

Tested the kvsWebrtcClientViewer with the kvsWebrtcClientMasterGstSample for H265/AAC to verify that the media
Tested the kvsWebrtcClientViewer with the kvsWebrtcClientMaster for H265/AAC, H264/OPUS, H265/OPUS to verify that the media
Tested the kvsWebrtcClientMasterGstSample and kvsWebrtcClientViewer with the browser's viewer but it runs into matroskamux matroska-mux.c:1134:gst_matroska_mux_video_pad_setcaps:<mux> error: Caps changes are not supported by Matroska from time to time but not always as the browser's changes the level while sending the media sometimes. This may require a more complex parsing logic.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov-commenter · 2024-04-03T05:03:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (5b98fc0) to head (4c61c55).

❗ Current head 4c61c55 differs from pull request most recent head e2e902e. Consider uploading reports for the commit e2e902e to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1963      +/-   ##
===========================================
- Coverage    88.79%   88.77%   -0.03%     
===========================================
  Files           45       45              
  Lines        12508    12510       +2     
===========================================
- Hits         11107    11106       -1     
- Misses        1401     1404       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md

samples/GstAudioVideoReceiver.c

samples/Samples.h

src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h

samples/kvsWebRTCClientMasterGstSample.c

samples/Samples.h

samples/GstAudioVideoReceiver.c

.github/workflows/ci.yml

samples/GstAudioVideoReceiver.c

src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h

* create the gst receiver * fix ci * cmake flag * clang format, add cmake flag in ci * install gstreamer on ci * use macos12 * use defined values * indent * clang-format * readme and commentsa * clang :( * install glib to fix ci * -DCOMPILER_WARNINGS=FALSE to fix the CI * fix macos version for clang * address comments and cleanup * new viewer with gst * clang-format * missing null check * address comments * -DCOMPILER_WARNINGS=TRUE * clang-format * gst_init_check * fix CI * fix CI

* Add H265 and AAC frames (#1962) * aac and h265 frames * update readme * update cmake with h265 and aac * clang formay * [Sample] GStreamer media receiver (#1963) * create the gst receiver * fix ci * cmake flag * clang format, add cmake flag in ci * install gstreamer on ci * use macos12 * use defined values * indent * clang-format * readme and commentsa * clang :( * install glib to fix ci * -DCOMPILER_WARNINGS=FALSE to fix the CI * fix macos version for clang * address comments and cleanup * new viewer with gst * clang-format * missing null check * address comments * -DCOMPILER_WARNINGS=TRUE * clang-format * gst_init_check * fix CI * fix CI * [Bug] GStreamer sample (#1972) * gst-sample-fix * modify the message * fix windows * set to null * fix pts and eos in sample * unused var removed * move null init * Version check job (#1974) * Version check job * Working Version check template * Retest with dev * Version lint * Version lint * use new frames (#1978) * Sample TWCC implementation (#1957) * encoder bitrate change based on twcc * Change to 5% inc and dec * modify percentages * ema based calc * EMa fix * Nits * Readme * flip * memset remove * Readme update, move enable flags to createSampleConfiguration * Add codecov token * [Feature] Add H265 support with SDP, RTP payloader-deplayloader (#1965) * Add RtpH265Payloader.c and RtpH265Payloader.h * Add support for H265 in PeerConnection/SessionDescription * Add support for H265 in PeerConnection/PeerConnection * Add support for H265 in PeerConnection/Rtp * Add support for H265 in samples/Common.c * Add support for H265 in samples/kvsWebRTCClientMaster.c * rtp, sdp fix, flag removed, clang fixed, windows build fixed, new test added * test fix * cleanup * cleanup * remove #if 0 * clang * presentation ts fix * clang-format fix * PKG_CONFIG_PATH in kvscommon * missing bracket * fix all builds * ci * cleanup * fix windows build, rename h265 defs * remove duplicate line from h264 and h265 * sample changes * address comments * clang-format * gst sample * cleanup args * clang-format * cleanup * add sdp tests * address comments * address commentas * set default payload type only once * address comments * fix height and width * sdp change --------- Co-authored-by: Hongli Wang <[email protected]> * Version bump, fix tests, remove enableIceStats * Remove AAC related changes * Remove AAC frames * Clang format * fix kvsWebrtcClientMasterGstSample.c name in CMakeLists --------- Co-authored-by: Divya Sampath Kumar <[email protected]> Co-authored-by: Hongli Wang <[email protected]>

niyatim23 added 6 commits April 3, 2024 11:02

create the gst receiver

6d25322

fix ci

4a8e3a5

cmake flag

ec065ce

clang format, add cmake flag in ci

98acbeb

install gstreamer on ci

6264032

use macos12

df0fd21

niyatim23 force-pushed the viewer_gstreamer branch from 9c5ce8b to df0fd21 Compare April 3, 2024 18:03

niyatim23 added 8 commits April 3, 2024 14:05

use defined values

924501a

indent

c9f6d7f

clang-format

bb6073c

readme and commentsa

87ca4bb

clang :(

5abff78

install glib to fix ci

3080c92

-DCOMPILER_WARNINGS=FALSE to fix the CI

32a30f0

fix macos version for clang

1e17a95

niyatim23 requested review from disa6302 and sirknightj April 3, 2024 23:28

niyatim23 marked this pull request as ready for review April 3, 2024 23:32

niyatim23 changed the title ~~GStreamer media receiver~~ [Sample] GStreamer media receiver Apr 3, 2024

niyatim23 added GStreamer Samples labels Apr 3, 2024

sirknightj reviewed Apr 4, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

samples/GstAudioVideoReceiver.c Outdated Show resolved Hide resolved

samples/GstAudioVideoReceiver.c Show resolved Hide resolved

sirknightj reviewed Apr 4, 2024

View reviewed changes

samples/Samples.h Outdated Show resolved Hide resolved

sirknightj reviewed Apr 4, 2024

View reviewed changes

src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h Outdated Show resolved Hide resolved

disa6302 reviewed Apr 4, 2024

View reviewed changes

src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h Outdated Show resolved Hide resolved

samples/kvsWebRTCClientMasterGstSample.c Outdated Show resolved Hide resolved

samples/Samples.h Outdated Show resolved Hide resolved

niyatim23 added 3 commits April 4, 2024 09:27

address comments and cleanup

28e1c7f

new viewer with gst

059c345

clang-format

b0e55fd

sirknightj reviewed Apr 5, 2024

View reviewed changes

samples/GstAudioVideoReceiver.c Outdated Show resolved Hide resolved

sirknightj reviewed Apr 5, 2024

View reviewed changes

samples/GstAudioVideoReceiver.c Show resolved Hide resolved

missing null check

7fcd673

sirknightj previously approved these changes Apr 5, 2024

View reviewed changes

This was referenced Apr 7, 2024

[Feature] Extend supported codecs to H265 and AAC (experimental) #1946

Closed

[Feature] Add H265 support with SDP, RTP payloader-deplayloader #1965

Merged

[Feature] Add AAC Support #1966

Open

disa6302 reviewed Apr 9, 2024

View reviewed changes

address comments

603ebe9

niyatim23 dismissed sirknightj’s stale review via 603ebe9 April 9, 2024 17:17

niyatim23 added 5 commits April 9, 2024 10:19

-DCOMPILER_WARNINGS=TRUE

6ea776c

clang-format

83d6fea

gst_init_check

404f93d

fix CI

325a7c9

fix CI

e2e902e

disa6302 approved these changes Apr 11, 2024

View reviewed changes

stefankiesz approved these changes Apr 11, 2024

View reviewed changes

niyatim23 merged commit a07a25c into develop Apr 11, 2024
30 checks passed

niyatim23 deleted the viewer_gstreamer branch April 11, 2024 20:53

niyatim23 mentioned this pull request May 1, 2024

Release 1.10.2 #1979

Closed

niyatim23 mentioned this pull request May 2, 2024

Release 1.10.2 #1981

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Sample] GStreamer media receiver #1963

[Sample] GStreamer media receiver #1963

niyatim23 commented Apr 3, 2024 •

edited

Loading

codecov-commenter commented Apr 3, 2024 •

edited

Loading

[Sample] GStreamer media receiver #1963

[Sample] GStreamer media receiver #1963

Conversation

niyatim23 commented Apr 3, 2024 • edited Loading

codecov-commenter commented Apr 3, 2024 • edited Loading

Codecov Report

niyatim23 commented Apr 3, 2024 •

edited

Loading

codecov-commenter commented Apr 3, 2024 •

edited

Loading