Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1 7 3 #1473

Merged
merged 12 commits into from
May 19, 2022
Merged

Release 1 7 3 #1473

merged 12 commits into from
May 19, 2022

Conversation

jdelapla
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdelapla jdelapla closed this May 18, 2022
@jdelapla jdelapla reopened this May 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1473 (95aa443) into master (2dff44f) will decrease coverage by 34.50%.
The diff coverage is 10.43%.

@@             Coverage Diff             @@
##           master    #1473       +/-   ##
===========================================
- Coverage   85.85%   51.35%   -34.51%     
===========================================
  Files          42       46        +4     
  Lines       10783    12822     +2039     
===========================================
- Hits         9258     6585     -2673     
- Misses       1525     6237     +4712     
Impacted Files Coverage Δ
samples/Common.c 0.00% <0.00%> (ø)
samples/kvsWebRTCClientMaster.c 0.00% <0.00%> (ø)
samples/kvsWebRTCClientViewer.c 0.00% <0.00%> (ø)
src/source/Ice/TurnConnection.c 0.00% <0.00%> (-93.47%) ⬇️
src/source/PeerConnection/PeerConnection.c 81.25% <ø> (-4.93%) ⬇️
src/source/Signaling/LwsApiCalls.c 1.53% <0.00%> (-82.52%) ⬇️
src/source/Signaling/Signaling.c 11.58% <0.00%> (-84.01%) ⬇️
src/source/Signaling/StateMachine.c 0.00% <0.00%> (-83.12%) ⬇️
src/source/Ice/IceAgent.c 85.75% <17.39%> (-8.46%) ⬇️
src/source/Signaling/Client.c 83.82% <28.57%> (-11.04%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dff44f...95aa443. Read the comment docs.

@jdelapla jdelapla merged commit ced19d0 into master May 19, 2022
@jdelapla jdelapla deleted the release_1_7_3 branch May 19, 2022 00:15
disa6302 pushed a commit that referenced this pull request Dec 5, 2023
* recreate signaling client & lws_context whenever a significant error has occurred

* Clang format

* More verbose and debug logging for ice & turn

* Clang formatting

* travis be gone

* add github-actions

* more clang formatting

* more clang formatting

* address sanitizer

* fix clang-format

* fix client.c clang-format

Co-authored-by: Niyati Maheshwari <[email protected]>
disa6302 pushed a commit that referenced this pull request Dec 6, 2023
* recreate signaling client & lws_context whenever a significant error has occurred

* Clang format

* More verbose and debug logging for ice & turn

* Clang formatting

* travis be gone

* add github-actions

* more clang formatting

* more clang formatting

* address sanitizer

* fix clang-format

* fix client.c clang-format

Co-authored-by: Niyati Maheshwari <[email protected]>
@unicornss unicornss restored the release_1_7_3 branch August 16, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants