Update PIC git tag to include modified Threadpool teardown #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disa6302
reviewed
Sep 19, 2023
…bs/amazon-kinesis-video-streams-producer-c into modify-threadpool-teardown
disa6302
previously approved these changes
Sep 20, 2023
niyatim23
dismissed
disa6302’s stale review
The merge-base changed after approval.
disa6302
previously approved these changes
Sep 20, 2023
niyatim23
dismissed
disa6302’s stale review
The merge-base changed after approval.
disa6302
previously approved these changes
Sep 20, 2023
niyatim23
dismissed
disa6302’s stale review
The merge-base changed after approval.
sirknightj
previously approved these changes
Sep 20, 2023
niyatim23
dismissed
sirknightj’s stale review
The merge-base changed after approval.
disa6302
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
To fix the TSAN build issues with awslabs/amazon-kinesis-video-streams-webrtc-sdk-c#1806
Description of changes:
The PIC commit awslabs/amazon-kinesis-video-streams-pic#218 fixes the TSAN build issues in WebRTC. We need to modify the same in Producer C to propagate it to WebRTC.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.