-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.0 #267
Merged
Merged
Release 1.2.0 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply linting
Fix unit test when log level env variable is not set
CI enhancements: Code linter, PR description, speed up
* Add API for specifying thread stack size (#243) * Add API for specifying thread stack size * Add compile time default stack size * compile time definitions in cmake * add local variable for stack size in API * Adding temporary CMake Debug message * Removed debug message in CMakeLists.txt, added CMAKE flag to readme * Reset global variable before running new thread test * Remove duplicate code and unused variables * explicit cast * missing ) * enforce pthread min stack size * Change name of variable to have *_BYTES for readability * Update variable name to include 'bytes' by request * Addressing nit picks * bound rand stack size value to not exceed max * Remove rand() test on an OS wrapper API * Wake up github * Comment * Remove lower bound checking for pthread * Clang * StackSize and ConstrainedDevice incompatible; Additional unit tests for the thread create API; Add new CI job and script to check CMake flag compatibility * Add second case * Fix typo * Rename variables in the test * Address comments and add log line in case of conflict again --------- Co-authored-by: jdelapla <[email protected]>
unicornss
reviewed
Nov 9, 2024
unicornss
reviewed
Nov 9, 2024
* Change createThreadWithParams from size_t to versioned struct and add new negative test scenarios * Remove designated initializers * Fix capitalization * Add message to clarify that stack size is not set * Adjust status name and strengthen equality checks in the test * Adjust name in the windows path as well * Move the statuscode to the other location, adjust tooLargeThreadStack test for windows and linux * Fix missing parenthesis * Move the sleep into the guarded section * Rename variable in the test
unicornss
approved these changes
Nov 11, 2024
stefankiesz
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
Additional manual tests from producer-c using this dependency:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.