Update the Worker shutdown logic to make sure that the LeaseCleanup Manager also terminates all the threads that it has started #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager also terminates all the threads that it has started
kmz
changed the title
joshua-kim
approved these changes
Jul 1, 2021
|
Thanks for the PR. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #796
Description of changes:
Fix to cleanup the threads started by the LeaseCleanupManager when the Worker triggers a shutdown.
The same problem(#816) occurred on KCL2.x
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.