Add SdkException to exception manager of KinesisDataFetcher #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KinesisDataFetcher uses the AWSExceptionManager to translate execution exceptions into the expected exceptions. Currently if the exception is unexpected the exception will be wrapped in a RuntimeException before being returned. We depend on SdkExceptions being the right type where we handle them upstream so we add a configuration for SdkException which should ensure handling works as expected.
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Feb 18, 2019
https://github.com/awslabs/amazon-kinesis-client/milestone/29 * Fixed handling of the progress detection in the `ShardConsumer` to restart from the last accepted record, instead of the last queued record. * awslabs#492 * Fixed handling of exceptions when using polling so that it will no longer treat `SdkException`s as an unexpected exception. * awslabs#497 * awslabs#502 * Fixed a case where lease loss would block the `Scheduler` while waiting for a record processor's `processRecords` method to complete. * awslabs#501
sahilpalvia
pushed a commit
that referenced
this pull request
Feb 18, 2019
https://github.com/awslabs/amazon-kinesis-client/milestone/29 * Fixed handling of the progress detection in the `ShardConsumer` to restart from the last accepted record, instead of the last queued record. * #492 * Fixed handling of exceptions when using polling so that it will no longer treat `SdkException`s as an unexpected exception. * #497 * #502 * Fixed a case where lease loss would block the `Scheduler` while waiting for a record processor's `processRecords` method to complete. * #501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KinesisDataFetcher uses the AWSExceptionManager to translate
execution exceptions into the expected exceptions. Currently if the
exception is unexpected the exception will be wrapped in a
RuntimeException before being returned. We depend on SdkExceptions
being the right type where we handle them upstream so we add a
configuration for SdkException which should ensure handling works as
expected.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.