Fixing IOPs issue with lease table #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Making DynamoDBLeaseCoordinator take IOPs configuration in the constructor * InitialLeaseTableReadCapacity and InitialLeaseTableWriteCapacity for the DynamoDBLeaseCoordinator class throws UnsupportedException
pfifer
suggested changes
Aug 10, 2018
| } | ||
| this.initialLeaseTableReadCapacity = readCapacity; | ||
| return this; | ||
| throw new UnsupportedOperationException("Please set read capacity using the constructor"); |
There was a problem hiding this comment.
This is a breaking change. Keep the setting available. You can mark them as deprecated though.
| @@ -100,6 +110,8 @@ public DynamoDBLeaseCoordinator(final LeaseRefresher leaseRefresher, | |||
| final int maxLeasesForWorker, | |||
| final int maxLeasesToStealAtOneTime, | |||
| final int maxLeaseRenewerThreadCount, | |||
| final long initialLeaseTableReadCapacity, | |||
There was a problem hiding this comment.
As we just added the @KinesisClientInternalApi retain the existing constructor and chain them together. You can mark the original constructor as deprecated.
added 2 commits
August 10, 2018 10:08
* Reverting the constructor, and adding chained constructor * Reverting support for initial iops methods * Adding deprecated tags and notes to javadoc
* Introducing chained constructors in DynamoDBLeaseManagementFactory * Introducing TableConstants to maintain Default IOPS in one place
pfifer
approved these changes
Aug 13, 2018
pfifer
added
v2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.