Update to Multilang Daemon to support StreamArn #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2023 16:46
…so updated unit tests to be more explicit with the expected exceptions
…re consistent with other error messages
stair-aws
reviewed
Jun 17, 2023
...ang/src/main/java/software/amazon/kinesis/multilang/config/MultiLangDaemonConfiguration.java
Outdated
Show resolved
Hide resolved
added 10 commits
June 19, 2023 13:38
… as well). Also updated unit tests and added Region validation
…r than individual section
… support in multilangdaemon
stair-aws
reviewed
Jun 22, 2023
...ang/src/main/java/software/amazon/kinesis/multilang/config/KinesisClientLibConfigurator.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
97
to
100
| @Test(expected = IllegalArgumentException.class) | ||
| public void testConstructorFailsBecauseStreamArnIsInvalid2() throws Exception { | ||
| setup("", "arn:aws:kinesis:us-east-2:ACCOUNT_ID:BadFormatting:stream/" + TEST_STREAM_NAME_IN_ARN, TEST_REGION); | ||
| } |
There was a problem hiding this comment.
FYI: Parameterized would eliminate boilerplate for these similar tests.
No change needed.
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...ent-multilang/src/test/java/software/amazon/kinesis/multilang/MultiLangDaemonConfigTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/kinesis/multilang/config/KinesisClientLibConfiguratorTest.java
Show resolved
Hide resolved
… conventions and simplied kinesisClientLibConfiguration
stair-aws
approved these changes
Jun 26, 2023
|
|
||
| } | ||
|
|
||
| Validate.notBlank(configuration.getStreamName(), "Stream name or Stream Arn is required. Stream Arn takes precedence if both are passed in."); |
There was a problem hiding this comment.
+1 for attempt at signaling "Stream Arn takes precedence ..."
However, this validation message only surfaces if the stream name is blank. Perhaps there should be a log.warn(...) -- circa ~79, before configuration.setStreamName(...) -- that warns of the name-stomping if-and-only-if a provided stream name is about to be overridden by the stream from the ARN.
| assertNotNull(deamonConfig.getRecordProcessorFactory()); | ||
|
|
||
| assertEquals(EXE, deamonConfig.getRecordProcessorFactory().getCommandArray()[0]); |
There was a problem hiding this comment.
Are we only interested in the 0th element (and if so, why?), or should this compare the full array? Example:
assertEquals(new String[] { EXE }, dC.getRPF().getCA());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Extension of PR 1141 - Moved from branch to fork
Description of changes:
==========================================================================================
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.