Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent HashRangesAreAlwaysComplete test from building invalid hierarchy trees #1066

Merged

Conversation

furq-aws
Copy link
Contributor

@furq-aws furq-aws commented Mar 16, 2023

Issue #, if available:
N/A

Description of changes:
Updates depth value for Merge and Reshard with some In-Progress Parents tests to prevent invalid hierarchy trees.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds mechanism to allow in-progress parents to finish (marked as SHARD_END) if testFor1000DifferentValidReshardHierarchyTreeWithSomeInProgressParentsTheHashRangesAreAlwaysComplete detects hole due to merged parent shards still holding an active lease.
@furq-aws furq-aws requested a review from stair-aws March 16, 2023 18:52
@furq-aws furq-aws marked this pull request as ready for review March 16, 2023 18:55
@furq-aws furq-aws requested a review from chenylee-aws March 20, 2023 10:37
@stair-aws stair-aws added the v2.x Issues related to the 2.x version label Mar 20, 2023
Updates depth value for Merge and Reshard with some In-Progress Parents tests to prevent invalid hierarchy trees.
Updates depth value for Merge and Reshard with some In-Progress Parents tests to prevent invalid hierarchy trees.
@furq-aws furq-aws merged commit 0627ba5 into awslabs:master Mar 22, 2023
@furq-aws furq-aws deleted the hashrangesarealwayscomplete-flakytest branch March 22, 2023 16:33
@furq-aws furq-aws changed the title Fix flaky HashRangesAreAlwaysComplete test Prevent HashRangesAreAlwaysComplete test from building invalid hierarchy trees Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.x Issues related to the 2.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants