Suppress LeaseAssignmentManager excessive WARN logs when there is no …

…issue (#1437) This commit fixes #1407. The WARN level log statements should only be executed when a real problem had been detected.
awslabs · Feb 7, 2025 · 68a7a9b · 68a7a9b
1 parent ae9a433
commit 68a7a9b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.../src/main/java/software/amazon/kinesis/coordinator/assignment/LeaseAssignmentManager.java b/.../src/main/java/software/amazon/kinesis/coordinator/assignment/LeaseAssignmentManager.java
@@ -537,8 +537,8 @@ public void loadInMemoryStorageView(final MetricsScope metricsScope) throws Exce
                     .filter(workerMetrics -> !workerMetrics.isValidWorkerMetric())
                     .map(WorkerMetricStats::getWorkerId)
                     .collect(Collectors.toList());
-            log.warn("List of workerIds with invalid entries : {}", listOfWorkerIdOfInvalidWorkerMetricsEntry);
             if (!listOfWorkerIdOfInvalidWorkerMetricsEntry.isEmpty()) {
+                log.warn("List of workerIds with invalid entries : {}", listOfWorkerIdOfInvalidWorkerMetricsEntry);
                 metricsScope.addData(
                         "NumWorkersWithInvalidEntry",
                         listOfWorkerIdOfInvalidWorkerMetricsEntry.size(),
@@ -567,8 +567,8 @@ public void loadInMemoryStorageView(final MetricsScope metricsScope) throws Exce
 
             final Map.Entry<List<Lease>, List<String>> leaseListResponse = leaseListFuture.join();
             this.leaseList = leaseListResponse.getKey();
-            log.warn("Leases that failed deserialization : {}", leaseListResponse.getValue());
             if (!leaseListResponse.getValue().isEmpty()) {
+                log.warn("Leases that failed deserialization : {}", leaseListResponse.getValue());
                 MetricsUtil.addCount(
                         metricsScope,
                         "LeaseDeserializationFailureCount",