added nfs-utils, and fix the way docker is installed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! 👍 |
jhaynes
reviewed
Jul 12, 2018
install-worker.sh
Outdated
| @@ -44,7 +45,7 @@ sudo systemctl enable iptables-restore | |||
| ################################################################################ | |||
|
|
|||
| sudo yum install -y yum-utils device-mapper-persistent-data lvm2 | |||
| sudo yum install -y docker | |||
| sudo amazon-linux-extras install -y docker | |||
There was a problem hiding this comment.
👍
In the interest of being explicit, I might write this as two separate lines:
sudo amazon-linux-extras enable docker
sudo yum install -y docker
There was a problem hiding this comment.
I make the changes as your comment, and fully agree is a lot more clear that way
commit 1ea10a7 Author: Marcelo Bartsch <[email protected]> Date: Fri Jul 13 09:21:06 2018 +0100 reset to original files commit 2aa7117 Author: Marcelo Bartsch <[email protected]> Date: Thu Jul 12 21:28:12 2018 +0100 make the enable amazon-linux-extra and enable docker a two step operation commit 75805b0 Author: Marcelo Bartsch <[email protected]> Date: Wed Jul 11 11:16:52 2018 +0100 added source_ami_id as a empty variable
add nfs-utils package
|
Hey thanks for the PR! We actually needed to pin docker to |
Could you explain why, please, @micahhausler? Or is this documented somewhere? |
306-san
referenced
this pull request
in 306-san/amazon-eks-ami
Aug 14, 2019
…w_error Fix fs.inotify error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1
Description of changes:
Docker on Amazon Linux 2 is a amazon linux extra and not part of the 'core' distribution, to install docker you need to use amazon-linux-extras command.
Also added nfs-utils to the worker image as in my test I'm using EFS to store data
Also added the source_ami_id variable, as an empty one, as mention in Issue #1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.