-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for Calico operator #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change needed but otherwise LGTM.
doc_source/calico.md
Outdated
|
||
``` | ||
curl -o calico.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico.yaml | ||
curl -o calico-operator.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico-operator.yaml | ||
curl -o calico-crs.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico-operator.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was suppose to be calico-crs.yaml.
I get 404 errors for all the new links in this PR. |
@jimdial-aws Yeah, I'm not sure how to order these, so would appreciate guidance on what the right process is. This PR depends on the changes in this one: aws/amazon-vpc-cni-k8s#1410 I think the links probably need to be updated for the next release (v1.8?). The changes in that PR (1410) are against master. |
@caseydavenport Once the other PR changes are merged and these links are live, I'll look at merging this again. Thanks. |
I have merged this aws/amazon-vpc-cni-k8s#1410 to master. |
Thanks @jayanthvn! Is there a way to make this docs update in such a way that it will go live with the next release from master (v1.8)? |
I'll watch for the change to go live and try to make the docs change as soon as possible, but it may not be until Monday, depending on when the change goes live. |
264d9f6
to
bf6de3e
Compare
Thank you for your submission! |
Issue #, if available:
Description of changes:
This is a documentation PR that corresponds with the following changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.