transport/http: Add fix for HTTP request stream not seekable #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a fix for the HTTP Request setStream to correctly handle empty and empty unseekable teams. This fixes a bug where the HTTP request would attempt to rewind an empty unseekable stream due to assumptions that the stream would be nil if content length is 0. Related to #356
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Mar 8, 2022
Fixes SDK's checksum handling of require checksum with unseekable streams. Adds additional unit tests to validate the expected behavior of empty streams that are unseekable. Related to aws/smithy-go#357
skmcgrail
approved these changes
Mar 8, 2022
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Mar 8, 2022
Fixes SDK's checksum handling of require checksum with unseekable streams. Adds additional unit tests to validate the expected behavior of empty streams that are unseekable. Related to aws/smithy-go#357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix for the HTTP Request setStream to correctly handle empty
and empty unseekable teams. This fixes a bug where the HTTP request
would attempt to rewind an empty unseekable stream due to assumptions
that the stream would be nil if content length is 0.
Related to #356