Refactor encoding packages to be nested under common package #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is |
|
time was moved mainly because it had encoding and decode helpers. :/ though that doesn't fit well with the |
Updates the encoding packages, time, httpbinding, json and xml to all be nested under a common package, encoding
jasdel
force-pushed
the
jasdel/refactorEncodingPkg
branch
from
d937999 to
18a5032
Compare
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Dec 16, 2020
Updates the SDK to depend on the relocated smithy-go httpbinding, json, and xml packages. Depends on aws/smithy-go#242
skotambkar
approved these changes
Dec 16, 2020
Comment on lines
-1
to
-9
| package smithy | ||
|
|
||
| // The MediaType interface is intended to be implemented by string and | ||
| // byte array types whose values can be defined by RFC638 media types. | ||
| type MediaType interface { | ||
| // Describes the contents of the string or byte array using a media type | ||
| // as defined by RFC6838. | ||
| MediaType() string | ||
| } |
There was a problem hiding this comment.
yeah this type wasn't used at all and was an artifact that was never deleted from an old design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the encoding packages,
httpbinding,jsonandxmlto all be nested under a common package,encoding