update for java idiomatic style, and update smithy-go version

aws · Apr 30, 2021 · 9315ba7 · 9315ba7
1 parent 342f8a2
commit 9315ba7
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 28 deletions.
diff --git a/...smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SmithyGoDependency.java b/...smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SmithyGoDependency.java
@@ -118,7 +118,7 @@ private static GoDependency relativePackage(
     private static final class Versions {
         private static final String GO_STDLIB = "1.15";
         private static final String GO_CMP = "v0.5.4";
-        private static final String SMITHY_GO = "v1.3.1";
+        private static final String SMITHY_GO = "v1.3.2-0.20210427182611-342f8a297d6e";
         private static final String GO_JMESPATH = "v0.4.0";
     }
 }
diff --git a/.../src/main/java/software/amazon/smithy/go/codegen/integration/DocumentShapeSerVisitor.java b/.../src/main/java/software/amazon/smithy/go/codegen/integration/DocumentShapeSerVisitor.java
@@ -325,11 +325,14 @@ private void generateSerFunction(
 
         Symbol symbol = symbolProvider.toSymbol(shape);
 
-        String functionName = shape.hasTrait(SyntheticClone.class)
-                ? ProtocolGenerator.getOperationDocumentSerFuncName(
-                shape, context.getProtocolName())
-                : ProtocolGenerator.getDocumentSerializerFunctionName(
-                shape, context.getService(), context.getProtocolName());
+        String functionName;
+        if (shape.hasTrait(SyntheticClone.class)) {
+           functionName = ProtocolGenerator.getOperationDocumentSerFuncName(
+                   shape, context.getProtocolName());
+        } else {
+            functionName = ProtocolGenerator.getDocumentSerializerFunctionName(
+                    shape, context.getService(), context.getProtocolName());
+        }
 
         String additionalArguments = getAdditionalSerArguments().entrySet().stream()
                 .map(entry -> String.format(", %s %s", entry.getKey(), entry.getValue()))

diff --git a/...main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java b/...main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java
@@ -666,14 +666,14 @@ private void writeHttpBindingSetter(
     }
 
     private void writeHttpBindingMember(
-            final GenerationContext context,
+            GenerationContext context,
             HttpBinding binding
     ) {
         GoWriter writer = context.getWriter();
         Model model = context.getModel();
         MemberShape memberShape = binding.getMember();
-        final Shape targetShape = model.expectShape(memberShape.getTarget());
-        final HttpBinding.Location location = binding.getLocation();
+        Shape targetShape = model.expectShape(memberShape.getTarget());
+        HttpBinding.Location location = binding.getLocation();
 
         // return an error if member shape targets location label, but is unset.
         if (location.equals(HttpBinding.Location.LABEL)) {
@@ -782,28 +782,18 @@ private void writeQueryBinding(
                     .getMember();
             writer.openBlock("for i := range $L {", "}", operand, () -> {
                 GoValueAccessUtils.writeIfZeroValue(context.getModel(), writer, collectionMember,
-                        operand + "[i]", () -> {
-                            writer.write("continue");
-                        });
+                        operand + "[i]", () -> writer.write("continue"));
+
+                String addQuery = String.format("$L.AddQuery(%s).$L", isQueryParams ? "$L" : "$S");
                 writeHttpBindingSetter(context, writer, collectionMember, location, operand + "[i]",
-                        (w, s) -> {
-                            if (isQueryParams) {
-                                w.writeInline("$L.AddQuery($L).$L", dest, locationName, s);
-                            } else {
-                                w.writeInline("$L.AddQuery($S).$L", dest, locationName, s);
-                            }
-                        });
+                        (w, s) -> w.writeInline(addQuery, dest, locationName, s));
             });
-        } else {
-            writeHttpBindingSetter(context, writer, memberShape, location, operand,
-                    (w, s) -> {
-                        if (isQueryParams) {
-                            w.writeInline("$L.SetQuery($L).$L", dest, locationName, s);
-                        } else {
-                            w.writeInline("$L.SetQuery($S).$L", dest, locationName, s);
-                        }
-                    });
+            return;
         }
+
+        String setQuery = String.format("$L.SetQuery(%s).$L", isQueryParams ? "$L" : "$S");
+        writeHttpBindingSetter(context, writer, memberShape, location, operand,
+                (w, s) -> w.writeInline(setQuery, dest, locationName, s));
     }
 
     private void writeHeaderBinding(