-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularise the repository #33
base: mainline
Are you sure you want to change the base?
Conversation
* Move packages containing entrypoints into the `cmd` package. * Move all other packages into the `pkg` package. * Declare all third-party dependencies in `go.mod`. * Update support scripts/files to handle new repository layout.
@@ -26,7 +26,7 @@ package:: create-package-folder package-rpm-amd64 package-rpm-386 package-rpm-ar | |||
release:: clean checkstyle release-test pre-release build prepack package copy-package-dependencies | |||
|
|||
clean:: remove-prepacked-folder | |||
rm -rf build/* bin/ pkg/ vendor/bin/ vendor/pkg/ .cover/ | |||
rm -rf build/* bin/ pkg/ .cover/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm -rf build/* bin/ pkg/ .cover/ | |
rm -rf build/* bin/ .cover/ |
It looks like some files that shouldn't be cleaned up have been moved into pkg
Hi @chrisnovakovic, Thanks, |
@Yangtao-Hua Any idea when it will be merged or an answer as this would help enhance a lot of internal tooling that uses this tool. |
Issue #, if available: #1
Description of changes:
In PR #11, @bwagner5 refactored the code base as a Go module. Unfortunately, there were half a dozen other unrelated changes in the same PR, which have perhaps contributed to it not being merged. This PR is limited solely to the modularisation of the code, without the other changes that you may or may not want to accept.
vendor/
directory, even though this takes place in the following commit.vendor/
. This is a separate commit because of how noisy the deletion of the vendorised code is compared with the changes made in the first commit.make checkstyle
fails, but it's currently failing on the mainline branch anyway (see #17), and it at least fails in the same way after these changes (in fact the new changes make it fail slightly less with Go 1.17). Withcheckstyle
turned into a no-op in the Makefile, I was able to build working binaries withmake build-linux-amd64
and a working Debian package withmake package-deb-amd64
.make quick-test
behaves as expected, and passes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.