chore(tests): Adding any tests #2053

jfuss · 2021-06-08T14:05:15Z

Is a work in progress PR for adding tests related to the "any" method in API Gateway.

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

Write/update tests
make pr passes
Update documentation
Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2021-06-08T15:16:24Z

Codecov Report

Merging #2053 (ee3da9a) into develop (e7a1496) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2053      +/-   ##
===========================================
+ Coverage    93.58%   93.80%   +0.21%     
===========================================
  Files           90       91       +1     
  Lines         6124     6097      -27     
  Branches      1260     1261       +1     
===========================================
- Hits          5731     5719      -12     
+ Misses         183      174       -9     
+ Partials       210      204       -6

Impacted Files	Coverage Δ
samtranslator/plugins/exceptions.py	`83.33% <0.00%> (-2.39%)`	⬇️
samtranslator/model/iam.py	`94.59% <0.00%> (-1.16%)`	⬇️
samtranslator/model/sqs.py	`94.44% <0.00%> (-0.56%)`	⬇️
samtranslator/validator/validator.py	`95.23% <0.00%> (-0.42%)`	⬇️
samtranslator/sdk/resource.py	`89.74% <0.00%> (-0.26%)`	⬇️
samtranslator/open_api/open_api.py	`91.72% <0.00%> (-0.25%)`	⬇️
samtranslator/translator/arn_generator.py	`94.28% <0.00%> (-0.16%)`	⬇️
samtranslator/model/__init__.py	`97.57% <0.00%> (-0.08%)`	⬇️
samtranslator/plugins/globals/globals.py	`99.02% <0.00%> (-0.03%)`	⬇️
samtranslator/model/sam_resources.py	`91.21% <0.00%> (-0.02%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a1496...ee3da9a. Read the comment docs.

mndeveci

Wow thanks for working on all these tests, LGTM! Only one minor comment.

mndeveci · 2021-06-10T01:52:10Z

tests/translator/output/api_request_model.json

      "Properties": {
        "DeploymentId": {
-          "Ref": "HtmlApiDeploymentdd6198efe6"
-        }, 
+          "Ref": "HtmlApiDeploymentcb065c609e"


The hash change is not because of difference between py2 and py3, right?

I don't think it's because of py2 vs py3. Rather, since there's a new path added in the input template, I believe the hash change is due to swagger change.

@mndeveci @hawflau is correct. All changes here are due to adding new paths to an API Gateway and therefore changing the hashes. I thought about maybe splitting everything into new tests but figured this was easier on me and that there are no code changes, so the hashes and things changing were predictable and expected.

Thanks for the explanation @jfuss & @hawflau !

hawflau · 2021-06-10T04:15:24Z

LGTM in general!
I notice there's "api_with_swagger_authorizer_none.yaml" in the input dir, but there's not corresponding json files in the output dirs. It's weird that we actually don't have this included in "test_translator.py". Did we miss it for some reason? Or intentionally omit it?

jfuss · 2021-06-10T13:51:33Z

LGTM in general!
I notice there's "api_with_swagger_authorizer_none.yaml" in the input dir, but there's not corresponding json files in the output dirs. It's weird that we actually don't have this included in "test_translator.py". Did we miss it for some reason? Or intentionally omit it?

Hmm... Honestly I have no idea if it is a miss or omitted on purpose. Let me do some digging into the git history and see if I can't understand that.

jfuss · 2021-06-10T15:44:02Z

@hawflau I talked with @qingchm. It was just a miss from an earlier PR (he noticed we didn't have the input class but didn't add it to the list of tests to run). So I added it back in.

* Adding api_request_model any tests * Add any to api_request_model_openapi_3 cases * Add rest of relevant any test cases * Fix hashing to match python2 * add api_with_swagger_authorizer_none to be run * fix py2 hashes in api_with_swagger_authorizer_none tests Co-authored-by: Jacob Fuss <[email protected]>

* test: New test group to test for side effects (#2046) * test: New test group to test for side effects * refactor: Updated to use _compare_transform and test CN and GOV partitions * docs: fix dead link (#2045) * Percentage-based Enablement for Feature Toggle (#1952) * Percentage-based Enablement for Feature Toggle * Update Feature Toggle to accept stage, account_id and region during instanciation * remove unnecessary uses of dict.get method * Refactor feature toggle methods * Update test names * black reformat * Update FeatureToggle to require stage, region and account_id to instanciate * Update log message * Implement calculating account percentile based on hash of account_id and feature_name * Refactor _is_feature_enabled_for_region_config * Refactor dialup logic into its own classes * Add comments for dialup classes * Rename NeverEnabledDialup to DisabledDialup * chore(tests): Adding any tests (#2053) * Adding api_request_model any tests * Add any to api_request_model_openapi_3 cases * Add rest of relevant any test cases * Fix hashing to match python2 * add api_with_swagger_authorizer_none to be run * fix py2 hashes in api_with_swagger_authorizer_none tests Co-authored-by: Jacob Fuss <[email protected]> * Add modes support for RestApi (#2055) * Adding Mode passthrough property to RestApi with unit tests. * Adding integration test for Mode * Fixing sam-translate for manual translation. * running black formatting * Running black formatting, again. * Clearing pip-wheel-metadata. * Clearing tmp folder created by integ test. Co-authored-by: Tarun Mall <[email protected]> * chore: bump version to 1.38.0 (#2081) Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Chris Rehn <[email protected]> Co-authored-by: Wing Fung Lau <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Tarun Mall <[email protected]> Co-authored-by: Raymond Wang <[email protected]>

* test: New test group to test for side effects (#2046) * test: New test group to test for side effects * refactor: Updated to use _compare_transform and test CN and GOV partitions * docs: fix dead link (#2045) * Percentage-based Enablement for Feature Toggle (#1952) * Percentage-based Enablement for Feature Toggle * Update Feature Toggle to accept stage, account_id and region during instanciation * remove unnecessary uses of dict.get method * Refactor feature toggle methods * Update test names * black reformat * Update FeatureToggle to require stage, region and account_id to instanciate * Update log message * Implement calculating account percentile based on hash of account_id and feature_name * Refactor _is_feature_enabled_for_region_config * Refactor dialup logic into its own classes * Add comments for dialup classes * Rename NeverEnabledDialup to DisabledDialup * chore(tests): Adding any tests (#2053) * Adding api_request_model any tests * Add any to api_request_model_openapi_3 cases * Add rest of relevant any test cases * Fix hashing to match python2 * add api_with_swagger_authorizer_none to be run * fix py2 hashes in api_with_swagger_authorizer_none tests Co-authored-by: Jacob Fuss <[email protected]> * Add modes support for RestApi (#2055) * Adding Mode passthrough property to RestApi with unit tests. * Adding integration test for Mode * Fixing sam-translate for manual translation. * running black formatting * Running black formatting, again. * Clearing pip-wheel-metadata. * Clearing tmp folder created by integ test. Co-authored-by: Tarun Mall <[email protected]> * chore: bump version to 1.38.0 (#2081) Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Chris Rehn <[email protected]> Co-authored-by: Wing Fung Lau <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Tarun Mall <[email protected]> Co-authored-by: Raymond Wang <[email protected]> Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Chris Rehn <[email protected]> Co-authored-by: Wing Fung Lau <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Tarun Mall <[email protected]> Co-authored-by: Raymond Wang <[email protected]>

Adding api_request_model any tests

f360335

jfuss force-pushed the any-method-tests branch from b2bafbc to f360335 Compare June 8, 2021 15:09

jfuss added 3 commits June 8, 2021 14:14

Add any to api_request_model_openapi_3 cases

40ef6fd

Add rest of relevant any test cases

355211a

Fix hashing to match python2

a151008

jfuss marked this pull request as ready for review June 9, 2021 18:50

jfuss changed the title ~~chore(tests): Adding api_request_model any tests~~ chore(tests): Adding any tests Jun 9, 2021

mndeveci approved these changes Jun 10, 2021

View reviewed changes

add api_with_swagger_authorizer_none to be run

26f8a45

fix py2 hashes in api_with_swagger_authorizer_none tests

ee3da9a

hawflau approved these changes Jun 10, 2021

View reviewed changes

mndeveci approved these changes Jun 10, 2021

View reviewed changes

jfuss merged commit e59951f into aws:develop Jun 10, 2021

c2tarun mentioned this pull request Jul 16, 2021

Release/v1.38.0 (#2082) #2095

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(tests): Adding any tests #2053

chore(tests): Adding any tests #2053

jfuss commented Jun 8, 2021

codecov-commenter commented Jun 8, 2021 •

edited

Loading

mndeveci left a comment

mndeveci Jun 10, 2021

hawflau Jun 10, 2021

jfuss Jun 10, 2021

mndeveci Jun 10, 2021

hawflau commented Jun 10, 2021

jfuss commented Jun 10, 2021

jfuss commented Jun 10, 2021

chore(tests): Adding any tests #2053

chore(tests): Adding any tests #2053

Conversation

jfuss commented Jun 8, 2021

codecov-commenter commented Jun 8, 2021 • edited Loading

Codecov Report

mndeveci left a comment

Choose a reason for hiding this comment

mndeveci Jun 10, 2021

Choose a reason for hiding this comment

hawflau Jun 10, 2021

Choose a reason for hiding this comment

jfuss Jun 10, 2021

Choose a reason for hiding this comment

mndeveci Jun 10, 2021

Choose a reason for hiding this comment

hawflau commented Jun 10, 2021

jfuss commented Jun 10, 2021

jfuss commented Jun 10, 2021

codecov-commenter commented Jun 8, 2021 •

edited

Loading