Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1.36.0 (#2042) #2050

Merged
merged 1 commit into from
May 31, 2021
Merged

Release/v1.36.0 (#2042) #2050

merged 1 commit into from
May 31, 2021

Conversation

qingchm
Copy link
Contributor

@qingchm qingchm commented May 31, 2021

  • refactor: Optimize shared API usage plan handling (WIP #1973)

  • fix: use instance variables for generating shared api usage plan

  • add extra log statements

  • fix: Added SAR Support Check (fix: Added SAR Support Check #1972)

  • Added SAR Support Check

  • Added docstring and Removed Instance Initialization for Class Method

  • set log level explicitly

  • update pyyaml version to get the security update (chore: Upgrade PyYaml version to 5.4 #1974)

  • fix: use instance variables for generating shared api usage plan

  • add extra log statements

  • set log level explicitly

  • black formatting

  • black formatting

Co-authored-by: Cosh_ [email protected]
Co-authored-by: Mohamed Elasmar [email protected]

  • feat: Resource level attributes support (feat: Resource level attributes support #2008)

  • Fix for invalid MQ event source managed policy

  • Fix for invalid managed policy for MQ, included support for new MQ event source property, updated test cases

  • Black reformatting

  • Test case changes

  • Changed policy name

  • Modified test cases with new policy name

  • Added resource attributes and unit tests

  • Resource attributes initial work

  • Passthrough attributes for some resources, updated some tests

  • Resolve merge conflicts

  • Fixed a typo

  • Modified implicit api plugin for resource attributes support

  • Partial update of the tests

  • Partially updated test cases, black reformatted

  • Partially updated test templates

  • Partially updated test templates

  • Partially updated test templates

  • Added event bridge support for passthrough resource attributes

  • Partially updated test templates (up to function with amq kms)

  • Partially updated test templates (up to sns)

  • Partially updated test templates (all the ones left)

  • Prevented passthrough resource attributes from changing layer version hashes

  • Added test to verify resource passthrough precedence for implicit api

  • Modified tests related to lambda layer to revert the hash changes, keeping the hash the same with resource attributes added

  • fix: mutable default values in method definitions (fix: mutable default values in method definitions #1997)

  • fix: remove explicit logging level set in single module (fix: remove explicit logging level set in single module #1998)

  • run automated tests for resource level attribute support

  • Skipping metadata in layer hashing

  • Refactored the classes for TestTranslatorEndToEnd and TestResourceLevelAttributes to share the same parent class

  • Added new translator tests for version and layer resources

  • Added new unit tests

  • Removed after transform resource plugin

  • Black reformatting

  • Refactoring implicit api plugin support for DeletionPolicy and UpdateReplacePolicy

  • Refactoring to improve code quality

  • Added simple documentation

  • Black reformatting

  • Added input template that was missing

  • Refactoring: use sets instead of lists for implicit api plugin

  • Changing import to be compatible with py2.7

  • Changing test deployment hashes to their actual values

Co-authored-by: Mehmet Nuri Deveci [email protected]

Co-authored-by: Qingchuan Ma [email protected]

Co-authored-by: Mehmet Nuri Deveci [email protected]
Co-authored-by: Cosh_ [email protected]
Co-authored-by: Mohamed Elasmar [email protected]

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* refactor: Optimize shared API usage plan handling (#1973)

* fix: use instance variables for generating shared api usage plan

* add extra log statements

* fix: Added SAR Support Check (#1972)

* Added SAR Support Check

* Added docstring and Removed Instance Initialization for Class Method

* set log level explicitly

* update pyyaml version to get the security update (#1974)

* fix: use instance variables for generating shared api usage plan

* add extra log statements

* set log level explicitly

* black formatting

* black formatting

Co-authored-by: Cosh_ <[email protected]>
Co-authored-by: Mohamed Elasmar <[email protected]>

* feat: Resource level attributes support (#2008)

* Fix for invalid MQ event source managed policy

* Fix for invalid managed policy for MQ, included support for new MQ event source property, updated test cases

* Black reformatting

* Test case changes

* Changed policy name

* Modified test cases with new policy name

* Added resource attributes and unit tests

* Resource attributes initial work

* Passthrough attributes for some resources, updated some tests

* Resolve merge conflicts

* Fixed a typo

* Modified implicit api plugin for resource attributes support

* Partial update of the tests

* Partially updated test cases, black reformatted

* Partially updated test templates

* Partially updated test templates

* Partially updated test templates

* Added event bridge support for passthrough resource attributes

* Partially updated test templates (up to function with amq kms)

* Partially updated test templates (up to sns)

* Partially updated test templates (all the ones left)

* Prevented passthrough resource attributes from changing layer version hashes

* Added test to verify resource passthrough precedence for implicit api

* Modified tests related to lambda layer to revert the hash changes, keeping the hash the same with resource attributes added

* fix: mutable default values in method definitions (#1997)

* fix: remove explicit logging level set in single module (#1998)

* run automated tests for resource level attribute support

* Skipping metadata in layer hashing

* Refactored the classes for TestTranslatorEndToEnd and TestResourceLevelAttributes to share the same parent class

* Added new translator tests for version and layer resources

* Added new unit tests

* Removed after transform resource plugin

* Black reformatting

* Refactoring implicit api plugin support for DeletionPolicy and UpdateReplacePolicy

* Refactoring to improve code quality

* Added simple documentation

* Black reformatting

* Added input template that was missing

* Refactoring: use sets instead of lists for implicit api plugin

* Changing import to be compatible with py2.7

* Changing test deployment hashes to their actual values

Co-authored-by: Mehmet Nuri Deveci <[email protected]>

* chore: bump version to 1.36.0 (#2014)

* fix: Shared Usage Plan scenarios for Resource Level Attribute Support (#2040)

* do not propagate attributes to CognitoUserPool

* shared usage plan with propagated resource level attributes

* add unit tests

* Added test templates for shared usage plan with resource attributes

* Black reformatting

* Removing unused import

* fix python2 hashes

Co-authored-by: Qingchuan Ma <[email protected]>

Co-authored-by: Mehmet Nuri Deveci <[email protected]>
Co-authored-by: Cosh_ <[email protected]>
Co-authored-by: Mohamed Elasmar <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #2050 (e169f21) into master (c5d0ed2) will decrease coverage by 0.20%.
The diff coverage is 90.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
- Coverage   93.88%   93.68%   -0.21%     
==========================================
  Files          90       90              
  Lines        5954     6094     +140     
  Branches     1213     1249      +36     
==========================================
+ Hits         5590     5709     +119     
- Misses        168      178      +10     
- Partials      196      207      +11     
Impacted Files Coverage Δ
samtranslator/sdk/resource.py 90.00% <50.00%> (-10.00%) ⬇️
samtranslator/plugins/api/implicit_api_plugin.py 94.01% <85.45%> (-4.24%) ⬇️
samtranslator/model/sam_resources.py 91.23% <88.00%> (-0.85%) ⬇️
samtranslator/model/__init__.py 97.64% <91.66%> (-0.51%) ⬇️
samtranslator/model/api/api_generator.py 94.37% <93.33%> (-0.38%) ⬇️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/model/eventbridge_utils.py 100.00% <100.00%> (ø)
samtranslator/model/eventsources/cloudwatchlogs.py 100.00% <100.00%> (ø)
samtranslator/model/eventsources/pull.py 78.68% <100.00%> (-0.35%) ⬇️
samtranslator/model/eventsources/push.py 90.92% <100.00%> (-0.09%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d0ed2...e169f21. Read the comment docs.

@qingchm qingchm merged commit a3a99d3 into master May 31, 2021
@jfuss jfuss deleted the release/v1.36.0 branch October 8, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants