-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type hint of PySparkProcessor __init__ #3297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3297 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 645 645
Lines 55518 55518
=======================================
Hits 49871 49871
Misses 5647 5647 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d222eb9
to
e1fca83
Compare
knikure
approved these changes
Dec 1, 2022
navinsoni
approved these changes
Dec 2, 2022
mufaddal-rohawala
added a commit
that referenced
this pull request
Dec 9, 2022
This reverts commit c97c467.
mizanfiu
pushed a commit
to mizanfiu/sagemaker-python-sdk
that referenced
this pull request
Dec 13, 2022
gradientsky
pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
gradientsky
pushed a commit
to gradientsky/sagemaker-python-sdk
that referenced
this pull request
Dec 20, 2022
hballuru
pushed a commit
to hballuru/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
Shegufta
pushed a commit
to Shegufta/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
claytonparnell
pushed a commit
that referenced
this pull request
Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (#3297) * fix: fix PySparkProcessor __init__ params type (#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524) * fix: type hint of PySparkProcessor __init__ (#3297) * fix: fix PySparkProcessor __init__ params type (#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
mufaddal-rohawala
added a commit
to mufaddal-rohawala/sagemaker-python-sdk
that referenced
this pull request
Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
mufaddal-rohawala
added a commit
that referenced
this pull request
Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (#3297) * fix: fix PySparkProcessor __init__ params type (#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524) * fix: type hint of PySparkProcessor __init__ (#3297) * fix: fix PySparkProcessor __init__ params type (#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
jmahlik
pushed a commit
to jmahlik/sagemaker-python-sdk
that referenced
this pull request
Dec 22, 2022
gwang111
added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * feature: add describe inf rec api to session * feature: add describe inf rec api to session * feature: add describe inf rec api to session * add verbose logging in wait_for_inference_recommendations_job * improve unit tests * switch to cloudwatch logs * add unit tests * fix unit test * make default logging level to Verbose * address comments in PR * address some comments * fix typo missing s * add initial print because it took a while for cw logstream to appear * print and conditional optimizations and update tests * optimize log print * fix polling for logs empty events * cover empty event case * add spacing Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Raymond Liu <[email protected]>
gwang111
added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 5, 2023
* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * feature: add describe inf rec api to session * feature: add describe inf rec api to session * feature: add describe inf rec api to session * add verbose logging in wait_for_inference_recommendations_job * improve unit tests * switch to cloudwatch logs * add unit tests * fix unit test * make default logging level to Verbose * address comments in PR * address some comments * fix typo missing s * add initial print because it took a while for cw logstream to appear * print and conditional optimizations and update tests * optimize log print * fix polling for logs empty events * cover empty event case * add spacing Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Raymond Liu <[email protected]>
gwang111
added a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Jan 6, 2023
* feature: Add create inf rec api to session * save * fix error handling in submit. update docstring * add in job_name param * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * feature: add describe inf rec api to session * feature: add describe inf rec api to session * feature: add describe inf rec api to session * add verbose logging in wait_for_inference_recommendations_job * improve unit tests * switch to cloudwatch logs * add unit tests * fix unit test * make default logging level to Verbose * address comments in PR * address some comments * fix typo missing s * add initial print because it took a while for cw logstream to appear * print and conditional optimizations and update tests * optimize log print * fix polling for logs empty events * cover empty event case * add spacing Co-authored-by: Gary Wang <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Raymond Liu <[email protected]>
wcarpenter1-godaddy
pushed a commit
to wcarpenter1-godaddy/sagemaker-python-sdk
that referenced
this pull request
Feb 8, 2023
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
tejaschumbalkar
pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 17, 2023
tejaschumbalkar
pushed a commit
to tejaschumbalkar/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2023
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * fix: type hint of PySparkProcessor __init__ (aws#3297) * fix: fix PySparkProcessor __init__ params type (aws#3354) * fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524) * feature: AutoGluon 0.6.1 image_uris * feature: AutoGluon 0.6.1 image_uris * Added processors for training images for consistency * Formatting * Formatting Co-authored-by: Kevin <[email protected]> Co-authored-by: André Perez <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently the signature type
instance_type
andinstance_count
of thePySparkProcessor.__init__
is wrong.sagemaker-python-sdk/src/sagemaker/spark/processing.py
Lines 683 to 684 in 284ddbe
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.