Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type hint of PySparkProcessor __init__ #3297

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

NivekNey
Copy link
Contributor

@NivekNey NivekNey commented Aug 14, 2022

Description of changes:

Currently the signature type instance_type and instance_count of the PySparkProcessor.__init__ is wrong.

instance_type: Union[int, PipelineVariable],
instance_count: Union[str, PipelineVariable],

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #3297 (284ddbe) into master (284ddbe) will not change coverage.
The diff coverage is n/a.

❗ Current head 284ddbe differs from pull request most recent head d222eb9. Consider uploading reports for the commit d222eb9 to get more accurate results

@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         645      645           
  Lines       55518    55518           
=======================================
  Hits        49871    49871           
  Misses       5647     5647           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vikas0203 vikas0203 requested review from a team, navinsoni and knikure and removed request for a team November 23, 2022 21:28
@navinsoni navinsoni merged commit c97c467 into aws:master Dec 2, 2022
@NivekNey NivekNey deleted the patch-1 branch December 2, 2022 20:49
mufaddal-rohawala added a commit that referenced this pull request Dec 9, 2022
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
gradientsky pushed a commit to gradientsky/sagemaker-python-sdk that referenced this pull request Dec 20, 2022
gradientsky pushed a commit to gradientsky/sagemaker-python-sdk that referenced this pull request Dec 20, 2022
hballuru pushed a commit to hballuru/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
Shegufta pushed a commit to Shegufta/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
claytonparnell pushed a commit that referenced this pull request Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (#3297)

* fix: fix PySparkProcessor __init__ params type (#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)

* fix: type hint of PySparkProcessor __init__ (#3297)

* fix: fix PySparkProcessor __init__ params type (#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
mufaddal-rohawala added a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
mufaddal-rohawala added a commit that referenced this pull request Dec 21, 2022
* fix: type hint of PySparkProcessor __init__ (#3297)

* fix: fix PySparkProcessor __init__ params type (#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)

* fix: type hint of PySparkProcessor __init__ (#3297)

* fix: fix PySparkProcessor __init__ params type (#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
jmahlik pushed a commit to jmahlik/sagemaker-python-sdk that referenced this pull request Dec 22, 2022
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* add verbose logging in wait_for_inference_recommendations_job

* improve unit tests

* switch to cloudwatch logs

* add unit tests

* fix unit test

* make default logging level to Verbose

* address comments in PR

* address some comments

* fix typo missing s

* add initial print because it took a while for cw logstream to appear

* print and conditional optimizations and update tests

* optimize log print

* fix polling for logs empty events

* cover empty event case

* add spacing

Co-authored-by: Gary Wang <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Raymond Liu <[email protected]>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 5, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* add verbose logging in wait_for_inference_recommendations_job

* improve unit tests

* switch to cloudwatch logs

* add unit tests

* fix unit test

* make default logging level to Verbose

* address comments in PR

* address some comments

* fix typo missing s

* add initial print because it took a while for cw logstream to appear

* print and conditional optimizations and update tests

* optimize log print

* fix polling for logs empty events

* cover empty event case

* add spacing

Co-authored-by: Gary Wang <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Raymond Liu <[email protected]>
gwang111 added a commit to gwang111/sagemaker-python-sdk that referenced this pull request Jan 6, 2023
* feature: Add create inf rec api to session

* save

* fix error handling in submit. update docstring

* add in job_name param

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* feature: add describe inf rec api to session

* add verbose logging in wait_for_inference_recommendations_job

* improve unit tests

* switch to cloudwatch logs

* add unit tests

* fix unit test

* make default logging level to Verbose

* address comments in PR

* address some comments

* fix typo missing s

* add initial print because it took a while for cw logstream to appear

* print and conditional optimizations and update tests

* optimize log print

* fix polling for logs empty events

* cover empty event case

* add spacing

Co-authored-by: Gary Wang <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Raymond Liu <[email protected]>
wcarpenter1-godaddy pushed a commit to wcarpenter1-godaddy/sagemaker-python-sdk that referenced this pull request Feb 8, 2023
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
tejaschumbalkar pushed a commit to tejaschumbalkar/sagemaker-python-sdk that referenced this pull request Mar 17, 2023
tejaschumbalkar pushed a commit to tejaschumbalkar/sagemaker-python-sdk that referenced this pull request Mar 20, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* fix: type hint of PySparkProcessor __init__ (aws#3297)

* fix: fix PySparkProcessor __init__ params type (aws#3354)

* fix: Revert "fix: type hint of PySparkProcessor __init__" (aws#3524)

* feature: AutoGluon 0.6.1 image_uris

* feature: AutoGluon 0.6.1 image_uris

* Added processors for training images for consistency

* Formatting

* Formatting

Co-authored-by: Kevin <[email protected]>
Co-authored-by: André Perez <[email protected]>
Co-authored-by: Mufaddal Rohawala <[email protected]>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants