chore: fix GHA for merge-queue #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Dec 11, 2024
.github/workflows/codeql.yml
Outdated
| branches: [ "main" ] | ||
| branches: [main] |
There was a problem hiding this comment.
Which triggers does the merge queue need? Since this one already had merge_group, I assume it also needs push or pull_request?
There was a problem hiding this comment.
This one is an outlier, it already had merge-queue, push and pull_request. It is the only action with the branch name in double quotes, and the docs don't show that as example syntax.
jmayclin
approved these changes
Dec 11, 2024
lrstewart
reviewed
Dec 11, 2024
lrstewart
approved these changes
Dec 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dougch
commented
Dec 11, 2024
|
|
||
| jobs: | ||
| regression-test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| if: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Only run this on PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Missing event types for 3 GHA to trigger on merge queues.
Call-outs:
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? relying on the CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.