ci: add change directory to third-party-src logic #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
approved these changes
Dec 5, 2024
jmayclin
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
I think this is fine for now, but can we open an issue to just have the other copies of code mode themselves to the "root" directory?
Moving the other code to root would be a change in one place, but the current approach requires each of our buildspecs to have this if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We want to use
GeneralBatchto replaceOmnibus. After PR #4913, PR #4945, and PR #4946 are merged,GeneralBatchprovides more coverage thanOmnibus, so we can useGeneralBatchto deprecate the rest ofOmnibus. However, there are four buildspec files inGeneralBatchthat are lacking the logic to cd into thethird-party-srcdirectory during the release process. Hence, this PR will add those logics for the release process to run properly.Call-outs:
Another way to resolve such problem is to remove the
third-party-srcdirectory. However, that would present risks for users who build s2n-tls with their own scripts. Some of their directories might conflict with ours.Testing:
GeneralBatchwill be triggered by the Lambda function. Testing results is attached to this PR:s2nGeneralBatch.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.