Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bench): remove historical benchmarks #4940

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

jmayclin
Copy link
Contributor

Resolved issues:

Related to some discussion in #4847

Description of changes:

In the last 18 months

  1. historical benchmarks haven't been used
  2. memory benchmarking hasn't been used (and breaks when I try to build it)
  3. feature gating hasn't been used

Remove the unused functionality to simplify things. If someone really wanted to use this they could always restore it from git history.

Testing:

Ensured that the bench command still ran.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmayclin jmayclin marked this pull request as ready for review November 27, 2024 00:26
@jmayclin jmayclin enabled auto-merge December 12, 2024 17:20
@jmayclin jmayclin added this pull request to the merge queue Dec 12, 2024
Merged via the queue into aws:main with commit 2e79e7e Dec 12, 2024
40 checks passed
@jmayclin jmayclin deleted the remove-historical-bench branch December 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants