Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Installs Nix in AL2023 Buildspec #4934

Merged
merged 16 commits into from
Dec 10, 2024

Conversation

maddeleine
Copy link
Contributor

Release Summary:

N/A

Resolved issues:

N/A

Description of changes:

Installs Nix in our buildspec for KTLS. My understanding of this issue is that build environments "sometimes" get reused, and "sometimes" they do not. So if we want to ensure Nix exists, we need to install it ourselves.

Call-outs:

N/A

Testing:

ktls tests pass: https://tiny.amazon.com/qzqz64ll/IsenLink

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maddeleine maddeleine requested a review from dougch as a code owner November 26, 2024 01:33
@maddeleine maddeleine requested a review from lrstewart November 26, 2024 20:16
Comment on lines 14 to 15
# Install nix
- sh <(curl -L https://nixos.org/nix/install) --no-daemon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary as opposed to just vanilla curl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curl command inside the parentheses gets the installation script. However, in order to actually run the script you have to pipe it to sh. I'm basically just following the nix install guide https://nix.dev/manual/nix/2.18/installation/installation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably also work:
curl -L https://nixos.org/nix/install | sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably also work: curl -L https://nixos.org/nix/install | sh

We want that --no-daemon flag.

@maddeleine maddeleine requested a review from lrstewart November 27, 2024 00:45
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit; thatnks for doing this

codebuild/spec/buildspec_al2023_ktls.yml Outdated Show resolved Hide resolved
Comment on lines 14 to 15
# Install nix
- sh <(curl -L https://nixos.org/nix/install) --no-daemon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably also work: curl -L https://nixos.org/nix/install | sh

We want that --no-daemon flag.

@maddeleine maddeleine enabled auto-merge (squash) December 3, 2024 23:20
@maddeleine maddeleine merged commit 9622cf4 into aws:main Dec 10, 2024
39 checks passed
@maddeleine maddeleine deleted the install_nix_ktls branch December 10, 2024 20:43
maddeleine added a commit to maddeleine/s2n that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants