Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update stateful resumption doc #4818

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Oct 3, 2024

Resolved issues:

When attempting to perform session resumption using session caching, the TLS connection must be closed gracefully. If not, the errored session cache is deleted from the server, leading to a failed resumption and triggering a full handshake instead. We should document this behavior and update the usage guide.

Description of changes:

Updated usage guide and documented stateful resumption behavior.

Call-outs:

Stateless session resumption behaves differently as it is able to resume a session without graceful TLS shutdown. This shouldn't have security implications as stated in RFC5077:

In the analysis within this paper, failure to invalidate
sessions does not pose a security risk. This is because the TLS
handshake uses a non-reversible function to derive keys for a session
so information about one session does not provide an advantage to
attack the master secret or a different session.

Testing:

No functional changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Oct 3, 2024
@jouho jouho marked this pull request as ready for review October 3, 2024 21:01
@jouho jouho requested review from goatgoose and lrstewart October 3, 2024 21:01
@jouho jouho requested a review from lrstewart October 4, 2024 19:24
docs/usage-guide/topics/ch11-resumption.md Outdated Show resolved Hide resolved
docs/usage-guide/topics/ch11-resumption.md Outdated Show resolved Hide resolved
docs/usage-guide/topics/ch11-resumption.md Outdated Show resolved Hide resolved
Copy link
Contributor

@goatgoose goatgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also meta-nit: this seems more like a docs PR than a chore

@jouho jouho changed the title chore: update stateful resumption doc docs: update stateful resumption doc Oct 7, 2024
- clarify only errored session will be evicted from cache
- clarify abrupt termination is an error
@jouho jouho requested a review from goatgoose October 7, 2024 18:28
docs/usage-guide/topics/ch11-resumption.md Outdated Show resolved Hide resolved
- document when the delete callback is called + its implication
@jouho jouho requested a review from lrstewart October 7, 2024 23:32
@jouho jouho requested review from lrstewart and goatgoose October 8, 2024 17:01
@jouho jouho enabled auto-merge (squash) October 8, 2024 21:05
@jouho jouho merged commit 4a1bfee into aws:main Oct 8, 2024
37 of 38 checks passed
@jouho jouho deleted the doc-update-stateful-resumption branch October 8, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants