Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prepare for auto amending implicit use of "default" security policy #4793

Closed
wants to merge 1 commit into from

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Sep 23, 2024

Description of changes:

This PR includes the manual changes needed before running the auto-generate script in #4778

Changes include:

  • adding s2n_auto_gen_old_default_security_policy which captures the current numbered equivalent of the default policies.
  • changing comments from s2n_config_new() -> s2n_config_new so that the auto script can match on that string

Testing:

Only test files were changed and current tests should continue to pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu
Copy link
Contributor Author

toidiu commented Sep 30, 2024

Implicit detection wont work so we need a better plan for that prior to making these manual changes.

@toidiu toidiu deleted the ak-prepImplicitDetection branch November 6, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant