test: avoid mutating static configs in tests #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-staticConfig
branch
from
219e535 to
a40ad5b
Compare
goatgoose
approved these changes
Sep 5, 2024
toidiu
force-pushed
the
ak-staticConfig
branch
from
a40ad5b to
bcdc37b
Compare
lrstewart
approved these changes
Sep 9, 2024
| EXPECT_SUCCESS(s2n_config_set_cipher_preferences(config, "20240501")); | ||
|
|
There was a problem hiding this comment.
Setting the cipher preferences to a specific security policy might be confusing given that you then immediately manually set the policy to NULL on line 257.
But I guess you're doing this pre-emptively as part of removing implicit defaults? It might actually be preferable to let whatever mechanism you're working on for that catch this. I know we discussed comments indicating that the call to set cipher preferences was added automatically as part of that work, which would clarify this logic.
There was a problem hiding this comment.
Yea its a bit odd in this test due to the immediate NULL-ing. Ill do as you suggest, remove it and fix it during the implicit detection.
toidiu
force-pushed
the
ak-staticConfig
branch
from
a3e3b75 to
788c53a
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
s2n-tls instantiates 3 static configs and sets them by default on a new config/connection objects. These static configs provide a sane configuration so that users can easily start using the library. Since the static configs represent a immutable value, we should avoid mutating them once they have been initialized.
This PR amends tests which were modifying the static configs.
Testing:
Tests should continues to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.