tests(pcaps): download additional pcaps #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Aug 27, 2024
lrstewart
force-pushed
the
ja4_tests_remote
branch
from
edaad7d to
cf398b1
Compare
lrstewart
commented
Aug 28, 2024
There was a problem hiding this comment.
I found some semi-related issues: #4741
I think they're unrelated enough to work better as a follow-up PR specifically focused on strange old tshark problems. The CI will be fine, but running the tests on older environments like Ubuntu18 will fail until I fix those issues.
camshaft
approved these changes
Aug 29, 2024
jmayclin
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add pcaps not generated by us to our pcaps tests.
Testing:
This adds inputs to existing tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.